Teams leave #136

SivamshIndukuri · 2025-08-18T16:53:42Z

I made an endpoint for members who leave a team and unit tests for it. I made a mock-up teamsDisband endpoint that needs to be replaced by the real function

Copilot

Pull Request Overview

This PR implements a new "teams leave" endpoint that allows team members to leave their team, with special handling for team leaders who trigger team disbandment instead. The implementation includes comprehensive unit tests covering various scenarios and error cases.

Adds a new /teams/leave POST endpoint with authentication and validation
Implements logic to handle member removal vs team disbandment for leaders
Provides comprehensive test coverage for all edge cases and success scenarios

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
src/functions/teams/leave/handler.ts	Main handler implementing team leave logic with member removal and leader disbandment
src/functions/teams/leave/schema.ts	JSON schema validation for the endpoint requiring auth_token, auth_email, and team_id
src/functions/teams/leave/index.ts	Serverless function configuration for the POST /teams/leave endpoint
tests/teams-leave.test.ts	Comprehensive unit tests covering authentication, edge cases, and success scenarios

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-18T18:21:38Z

tests/teams-leave.test.ts

+        // mock validToken fail
+        (validateToken as jest.Mock).mockReturnValue(true);
+
+        (teamsDisband as unknown as jest.Mock) = jest.fn();


This syntax is incorrect for TypeScript mock assignment. It should be (teamsDisband as jest.Mock) = jest.fn(); without the unknown cast.

Suggested change

(teamsDisband as unknown as jest.Mock) = jest.fn();

(teamsDisband as jest.Mock) = jest.fn();

Copilot · 2025-08-18T18:21:38Z

tests/teams-leave.test.ts

+        {
+            team_id: "team1234",
+            leader_email: "leader@gmail.com",
+            members: ["member1@gmail.com, member2@gmail.com"],


The members array contains a single string with comma-separated emails instead of separate string elements. It should be ["member1@gmail.com", "member2@gmail.com"] to properly test the logic.

Suggested change

members: ["member1@gmail.com, member2@gmail.com"],

members: ["member1@gmail.com", "member2@gmail.com"],

Copilot · 2025-08-18T18:21:39Z

src/functions/teams/leave/handler.ts

+import type { ValidatedEventAPIGatewayProxyEvent } from '@libs/api-gateway';
+import { middyfy } from '@libs/lambda';
+import schema from './schema';
+import { MongoDB, validateToken, UserDoc, TeamDoc, teamsDisband } from '../../../util'; //change to actual disband


[nitpick] The comment indicates this is temporary code that needs to be replaced. Consider using a proper TODO comment format like // TODO: Replace teamsDisband with actual implementation.

Suggested change

import { MongoDB, validateToken, UserDoc, TeamDoc, teamsDisband } from '../../../util'; //change to actual disband

import { MongoDB, validateToken, UserDoc, TeamDoc, teamsDisband } from '../../../util'; // TODO: Replace teamsDisband with actual implementation

Copilot · 2025-08-18T18:21:39Z

src/functions/teams/leave/handler.ts

+
+    // 8. Check if user is team lead
+    if(teamInfo.role == "leader"){
+      return await teamsDisband(auth_token, auth_email, team_id); //mocked function replace with right funtion name 


There's a typo in the comment: 'funtion' should be 'function'.

Suggested change

return await teamsDisband(auth_token, auth_email, team_id); //mocked function replace with right funtion name

return await teamsDisband(auth_token, auth_email, team_id); //mocked function replace with right function name

Copilot · 2025-08-18T18:21:40Z

src/functions/teams/leave/handler.ts

+      pending_invites: []
+    };
+
+    // 11. update the mondoDB user


There's a typo in the comment: 'mondoDB' should be 'MongoDB'.

Suggested change

// 11. update the mondoDB user

// 11. update the MongoDB user

avsomers25

Overall nice work! Just a few small things. to start make sure to run the linter and prettier before submitting a pr, and then take a look at the copilot comments there's a couple small things to fix. Lastly the teamDisband exists so you should update your code to use it. But most of this is great stuff!

SivamshIndukuri · 2025-08-19T04:47:12Z

Fixed all issues. Failing eslint because of the naming convention of auth_email, auth_token, team_id, which is how it is written in my issue. Can change if needed.

DaStormer · 2025-08-19T16:07:14Z

@SivamshIndukuri It's weird because we use camelCase for variables but snake_case for database properties and API request body. You can re-name the variables in destructuring

SivamshIndukuri · 2025-08-21T02:40:45Z

fixed all issues now

Ayoobf

Excellent work, I've added my suggestions!

Ayoobf · 2025-08-25T18:54:40Z

src/functions/teams/leave/handler.ts

+    // 7. Check if user is in team
+    if (!team.members.includes(authEmail)) {
+      return {
+        statusCode: 400,
+        body: JSON.stringify({ statusCode: 400, message: 'User not in team' }),
+      };
+    }


What if leader leaves the team? At the moment, attempting this operation will result in a "user not in team" error, when in reality, the team should be disbanded. As stated earlier, team.members does NOT include the team leader so you will have to explicitly check for that case.

Crude alternative but you get the point.

Suggested change

// 7. Check if user is in team

if (!team.members.includes(authEmail)) {

return {

statusCode: 400,

body: JSON.stringify({ statusCode: 400, message: 'User not in team' }),

};

}

// 7. Check if user is in team

if (!team.members.includes(authEmail) && team.leader_email !== (authEmail)) {

return {

statusCode: 400,

body: JSON.stringify({ statusCode: 400, message: 'User not in team' }),

};

}

Ayoobf · 2025-08-25T18:55:59Z

serverless.ts

export the teamsLeave endpoint HackRU-Backend\src\functions\index.ts as well.

Where do you want me to export the index.ts

Ayoobf · 2025-08-25T18:58:10Z

src/functions/teams/leave/handler.ts

+    // 6. No team members
+    if (team.members.length == 0) {
+      return {
+        statusCode: 400,
+        body: JSON.stringify({ statusCode: 400, message: 'Empty team member list' }),
+      };
+    }


What if a team leader wants to leave a team that has no members? as of right now, the team leader is not included in that team.members.length query. When taking into account a team's capacity, you should always do team.members.length + 1 to get all members including the leader.

Ayoobf · 2025-08-25T19:17:14Z

src/functions/teams/leave/handler.ts

+        body: JSON.stringify({ statusCode: 400, message: 'Team already disbanded' }),
+      };
+    }
+


Do a validation check on leader email. Simple if exists check will be enough. The reason why we want to do this is because we may do a leader_email check later on. To be fair, a team's state should never be in this spot (where a team has no leader) but just to be safe.

Do you want this check to be done if the leader wants to leave the team or always when running this endpoint

Either or is fine. I think they are functionally equal so I'll leave it to your best judgement.

SivamshIndukuri · 2025-09-03T19:32:58Z

Fixed team lead logic issues

SivamshIndukuri added 3 commits August 5, 2025 23:28

team leave end point

aa7b964

test cases and updated leave logic

45e8dbe

add one more case

e1245ae

Ayoobf assigned SivamshIndukuri Aug 18, 2025

Ayoobf requested review from Ayoobf, DaStormer, avsomers25 and Copilot August 18, 2025 18:20

Copilot AI reviewed Aug 18, 2025

View reviewed changes

avsomers25 requested changes Aug 18, 2025

View reviewed changes

SivamshIndukuri and others added 7 commits August 18, 2025 23:26

fixed to include disband endpoint

78e0bc6

fixed serverless.ts

2f9e603

Merge branch 'dev' into teams-leave

1f5b2b0

serverless.ts prettier

e4f7ba8

minor fixes

a60009d

typescript error fix

c41193a

typescript error fix

79ad216

SivamshIndukuri added 2 commits August 20, 2025 22:36

name change

05eaa6b

prettier

b2c44ac

Ayoobf requested changes Aug 25, 2025

View reviewed changes

SivamshIndukuri added 3 commits September 3, 2025 09:14

fixed lead logic

6b4f24c

valid team lead check

7318757

valid team lead check

b2d6008

	(teamsDisband as unknown as jest.Mock) = jest.fn();
	(teamsDisband as jest.Mock) = jest.fn();

	members: ["member1@gmail.com, member2@gmail.com"],
	members: ["member1@gmail.com", "member2@gmail.com"],

	import { MongoDB, validateToken, UserDoc, TeamDoc, teamsDisband } from '../../../util'; //change to actual disband
	import { MongoDB, validateToken, UserDoc, TeamDoc, teamsDisband } from '../../../util'; // TODO: Replace teamsDisband with actual implementation

	return await teamsDisband(auth_token, auth_email, team_id); //mocked function replace with right funtion name
	return await teamsDisband(auth_token, auth_email, team_id); //mocked function replace with right function name

	// 11. update the mondoDB user
	// 11. update the MongoDB user

Teams leave #136

Are you sure you want to change the base?

Teams leave #136

Uh oh!

Conversation

SivamshIndukuri commented Aug 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

avsomers25 left a comment

Choose a reason for hiding this comment

Uh oh!

SivamshIndukuri commented Aug 19, 2025

Uh oh!

DaStormer commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SivamshIndukuri commented Aug 21, 2025

Uh oh!

Ayoobf left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SivamshIndukuri commented Sep 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

DaStormer commented Aug 19, 2025 •

edited

Loading