Skip to content

Rework package #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sajacl wants to merge 63 commits into
base: main
Choose a base branch
from
Open

Rework package #4

sajacl wants to merge 63 commits into from

Conversation

@sajacl
Copy link

@sajacl sajacl commented Mar 18, 2024 •
edited
Loading

Proposing to rework branch based on observations.

Main key achievements:

  1. Improve readability.
  2. Extend functionality and provide a structured approach.

This PR will introduce some objects/logics which is listed below:

  • Characters
    Character objects will encapsulate bridge between Farsi justification and code implementation.

  • CoreTextExtendible
    Small weight objects (Line, Word) that will contain logics for re-aligning the given string.

  • Arabic evaluator

sajacl added 30 commits March 18, 2024 10:30
@sajacl
Remove comments.
081c98b
@sajacl
Remove extra white spaces.
24b2e1c
@sajacl
Revisit file in order to improve readability.
3b80603
@sajacl
Introduce ArabicStringEvaluator.
1201368 
Small object that can determine if an string/character is in Arabic.
@sajacl
Introduce ExtenderCharacter.
19ec1d6
@sajacl
Introduce MiniSpaceCharacter .
a907f6f
@sajacl
Introduce NewLine .
6b1ec6c
@sajacl
Introduce SpaceCharacter .
63fd8cb
@sajacl
Introduce Line.
a5e16ec
@sajacl
Introduce Word.
165a042
@sajacl
Introduce HeaderTypes.
f93975f
@sajacl
Remove unneeded variables.
96ce0c4
@sajacl
Introduce splitStringToLines method.
24ef91c
@sajacl
Introduce replaceDoubleEmptyLines method.
92e2724
@sajacl
Introduce justify method.
9152d2b
@sajacl
Remove getJustifiedLine method.
dea74ac
@sajacl
Remove getExtendedWords method.
e126f60
@sajacl
Remove isArabic computed property.
57130d4
@sajacl
Remove getWords method.
d78d161
@sajacl
Remove getTotalWidth method.
8819450
@sajacl
Remove getWordWidth method.
d542b74
@sajacl
Remove getRange method.
eaecc58
@sajacl
Remove isSupportExtender method.
6fcb92f
@sajacl
Remove hasRoomForNextWord method.
bcf1176
@sajacl
Remove joinWithSpace method.
ce47538
@sajacl
Introduce justifyLine method.
b328b5f
@sajacl
Refactor toPJString method.
871ac88
@sajacl
Add MeasurementTests file.
c996e36
@sajacl
Introduce MeasurementTests UIKit test case.
35e0daa
@sajacl
Introduce MeasurementTests AppKit test case.
cc4c4bd
sajacl and others added 10 commits March 18, 2024 13:34
@sajacl
Update call site.
c3d52f2
@HappyIosDeveloper
feat: Implemented "Create swift.yml" to add automated tests.
cd7cceb 
Implemented automation for unit testing to prevent broken commits into the project.
@HappyIosDeveloper
feat: Updated the Swift tools version to "5.10.0" on iml file to help…
07857b9 
… the GitHub automation do it's things and test the project.
@HappyIosDeveloper
GitHub: Downgraded the Swift tool version to fix the GitHub automatio…
a6dc74b 
…ns errors for uneven Swift tool version.
@HappyIosDeveloper
revert: Restored the Swift tool version to the 5.10 due to ruining th…
fe45392 
…e package functionality on my own machine.
@sajacl
Merge remote-tracking branch 'upstream/main' into rework-package
385c01e
@sajacl @MojtabaHs
Adopt new method signature.
27e0a28 
Co-Authored-By: Seyed Mojtaba Hosseini Zeidabadi <ca.chairman@gmail.com>
@sajacl
Removed unused files.
3039c71
@sajacl @TheAlienMann
Introduce new method linesProcessing.
937b3c5 
Mohammad's original commit:
r - extract linesProcessing

Co-Authored-By: Mohamad Rahmani <rahmanipour.mohammad@gmail.com>
@sajacl @TheAlienMann
Update call site, remove foreach and use new method.
60ac543 
Mohammad's original coomit:
r - use CharacterSet newlines instead of hardcoding newline + use components String's method and return an actual Array of String instead of a Substring (since you'll need to convert that again).

Co-Authored-By: Mohamad Rahmani <rahmanipour.mohammad@gmail.com>
@sajacl sajacl marked this pull request as ready for review March 19, 2024 10:03
MojtabaHs and others added 17 commits March 21, 2024 13:23
@MojtabaHs
build: use release configurations for the tests
ccf2080
@sajacl
Revert "Introduce new method linesProcessing."
26adb63 
This reverts commit 937b3c5.
@sajacl
Revert "Update call site, remove foreach and use new method."
e794367 
This reverts commit 60ac543.
@sajacl
Merge remote-tracking branch 'upstream/main' into rework-package
4a1d246
@sajacl
Move Typealias file.
e565ab4
@sajacl
Specify target path.
15a7621
@sajacl
Update MesurementTests.swift
9660b7e
@sajacl
Update MesurementTests.swift
bfee432
@sajacl
Add a new typealias named Label.
5358f93
@sajacl
Update method documentation.
3f6f92a
@sajacl
Remove default font argument value.
e5db0c6
@sajacl
Introduce new error PersianJustifyFailure.
2cdb47b
@sajacl
Add new method on Label named toPJString.
39f66d8
@sajacl
Decouple public interfaces from privates.
1b85866
@sajacl
Remove getFont and related test methods.
7b621d9
@sajacl
Add debugDescription for errorDescription in PersianJustifyFailure.
84e8034
@sajacl
Rename PersianJustifyFailure to PersianJustifyError.
0fca2aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sajacl @HappyIosDeveloper @MojtabaHs