Skip to content

Conversation

bpranava
Copy link
Contributor

@bpranava bpranava commented Jul 21, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 21, 2025
Copy link
Contributor

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

Copy link
Contributor

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 21, 2025
Copy link
Contributor

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 21, 2025
Copy link
Contributor

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

@bpranava
Copy link
Contributor Author

bpranava commented Jul 21, 2025

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave. @BrewTestBot will handle updating the bottle block before this PR is merged.

Can someone please help with this? Github detects deletion of file as a rename and the CI is blocked because it assumes I have removed the bottle do section from the original file. Not really sure how to proceed here

Copy link
Contributor

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Jul 22, 2025
@github-actions github-actions bot added go Go use is a significant feature of the PR or issue and removed automerge-skip `brew pr-automerge` will skip this pull request labels Jul 22, 2025
@bpranava
Copy link
Contributor Author

After this PR, please review - #230824

Github was misinterpreting file deletion as a rename, leading to CI failures. Hence I had to raise my changes on a separate branch.

carlocab added a commit that referenced this pull request Jul 22, 2025
We don't need to error out here if a formula is removed. This is also
fixes handling of formula renames. See, for example, #230744 or #230831.
carlocab added a commit that referenced this pull request Jul 22, 2025
We don't need to error out here if a formula is removed. This is also
fixes handling of formula renames. See, for example, #230744 or #230831.
@carlocab
Copy link
Member

The failure is a false positive. This will be fixed by #230832. You can combine your two PRs and rebase on main once #230832 is merged.

@carlocab
Copy link
Member

Closing this in favour of #230824 for now.

@carlocab carlocab closed this Jul 22, 2025
@bpranava
Copy link
Contributor Author

Thanks @carlocab!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants