Skip to content

wxwidgets 3.3.1 #230768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Jul 22, 2025
Merged

wxwidgets 3.3.1 #230768

merged 30 commits into from
Jul 22, 2025

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` alias labels Jul 21, 2025
@carlocab carlocab force-pushed the bump-wxwidgets-3.3.1 branch from bd2dd85 to ca27f21 Compare July 21, 2025 18:03
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 21, 2025
@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Jul 21, 2025
@carlocab carlocab added the long build Set a long timeout for formula testing label Jul 22, 2025
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 22, 2025
@carlocab carlocab mentioned this pull request Jul 22, 2025
@carlocab carlocab force-pushed the bump-wxwidgets-3.3.1 branch from 1c54548 to 825aee3 Compare July 22, 2025 05:01
@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Jul 22, 2025
@carlocab carlocab force-pushed the bump-wxwidgets-3.3.1 branch from 825aee3 to 322753a Compare July 22, 2025 05:10
@carlocab carlocab added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed automerge-skip `brew pr-automerge` will skip this pull request labels Jul 22, 2025
@carlocab
Copy link
Member

For reference, here is the old wxwidgets@3.0 formula that we probably want to copy as wxwidgets@3.2:

wxwdigets@3.0

class WxwidgetsAT30 < Formula
  desc "Cross-platform C++ GUI toolkit - Stable Release"
  homepage "https://www.wxwidgets.org"
  url "https://github.com/wxWidgets/wxWidgets/releases/download/v3.0.5.1/wxWidgets-3.0.5.1.tar.bz2"
  sha256 "440f6e73cf5afb2cbf9af10cec8da6cdd3d3998d527598a53db87099524ac807"
  license "LGPL-2.0-or-later" => { with: "WxWindows-exception-3.1" }
  revision 1

  bottle do
    sha256 cellar: :any,                 arm64_sonoma:   "73f2a8ef9d71f511c55e0cb2dd45d4fca4c02720d069f03e5cbfa89205be7094"
    sha256 cellar: :any,                 arm64_ventura:  "535e712315224e6bc4103dc9ad80553bae1e286100650dcf0d12b7f1f8811dbf"
    sha256 cellar: :any,                 arm64_monterey: "192d4777a1ed701f1cbb83fc089d5ab252b5f2114373878bf4afe0640fa061ea"
    sha256 cellar: :any,                 arm64_big_sur:  "856dac13f581c42ae3c176bbb3cb0054809d98b9d085ea97414737c5ddda2e8f"
    sha256 cellar: :any,                 sonoma:         "706381907cf8ed0b21277103760496bd88fc753b6e45603ae19013c4ba7d0420"
    sha256 cellar: :any,                 ventura:        "50257d9376ebedfe7fa03c918bda1e337620251e7ddecdae4c937aaa5384d38f"
    sha256 cellar: :any,                 monterey:       "15fa2f6d32e168ea5ce58a030421ebcd06327dabb0e5fa2bc8b39bb3a5e1e3e3"
    sha256 cellar: :any,                 big_sur:        "fbe7fd53da27ade071ea502e90f16a4037fa61d749ff018e3a887da60ea37595"
    sha256 cellar: :any,                 catalina:       "de311d5eddcecb5d75a53f8058471a47def9a7e5c55f104bb6bb996fb6e84374"
    sha256 cellar: :any_skip_relocation, x86_64_linux:   "f58f8970733e21c551874dd7085899a041b886b283dd15f29bf3880237c125e5"
  end

  disable! date: "2023-10-17", because: :versioned_formula

  depends_on "jpeg-turbo"
  depends_on "libpng"
  depends_on "libtiff"

  on_linux do
    depends_on "pkg-config" => :build
    depends_on "gtk+3"
    depends_on "libsm"
    depends_on "mesa-glu"
  end

  def install
    args = [
      "--prefix=#{prefix}",
      "--enable-clipboard",
      "--enable-controls",
      "--enable-dataviewctrl",
      "--enable-display",
      "--enable-dnd",
      "--enable-graphics_ctx",
      "--enable-std_string",
      "--enable-svg",
      "--enable-unicode",
      "--enable-webkit",
      "--enable-webview",
      "--with-expat",
      "--with-libjpeg",
      "--with-libpng",
      "--with-libtiff",
      "--with-opengl",
      "--with-zlib",
      "--disable-precomp-headers",
      # This is the default option, but be explicit
      "--disable-monolithic",
    ]

    if OS.mac?
      # Set with-macosx-version-min to avoid configure defaulting to 10.5
      args << "--with-macosx-version-min=#{MacOS.version}"
      args << "--with-osx_cocoa"
      args << "--with-libiconv"
    end

    system "./configure", *args
    system "make", "install"

    # wx-config should reference the public prefix, not wxwidgets's keg
    # this ensures that Python software trying to locate wxpython headers
    # using wx-config can find both wxwidgets and wxpython headers,
    # which are linked to the same place
    inreplace bin/"wx-config", prefix, HOMEBREW_PREFIX

    # Move some files out of the way to prevent conflict with `wxwidgets`
    bin.install bin/"wx-config" => "wx-config-#{version.major_minor}"
    (bin/"wxrc").unlink
    (share/"wx"/version.major_minor).install share/"aclocal", share/"bakefile"
  end

  def caveats
    <<~EOS
      To avoid conflicts with the wxwidgets formula, `wx-config` and `wxrc`
      have been installed as `wx-config-#{version.major_minor}` and `wxrc-#{version.major_minor}`.
    EOS
  end

  test do
    system bin/"wx-config-#{version.major_minor}", "--libs"
  end
end

@carlocab carlocab force-pushed the bump-wxwidgets-3.3.1 branch from 322753a to 8d20af6 Compare July 22, 2025 06:06
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 22, 2025
@carlocab carlocab force-pushed the bump-wxwidgets-3.3.1 branch from 8d20af6 to 7a6fa80 Compare July 22, 2025 07:13
@carlocab carlocab added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request ready to merge PR can be merged once CI is green labels Jul 22, 2025
@carlocab
Copy link
Member

Looks like some of these formulae are not linking with wxwidgets. They'll need to be switched to wxwidgets@3.2.

@carlocab carlocab mentioned this pull request Jul 22, 2025
6 tasks
carlocab added a commit that referenced this pull request Jul 22, 2025
This will be needed after #230768. This isn't included there since
`erlang@25` is deprecated, but it is easy enough to fix now so let's
keep it working until it's disabled next month.
Copy link
Contributor

:shipit: @carlocab has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 22, 2025
@BrewTestBot BrewTestBot enabled auto-merge July 22, 2025 12:47
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 22, 2025
carlocab added a commit that referenced this pull request Jul 22, 2025
This will be needed after #230768. This isn't included there since
`erlang@25` is deprecated, but it is easy enough to fix now so let's
keep it working until it's disabled next month.
Merged via the queue into main with commit 1dd0876 Jul 22, 2025
22 checks passed
@BrewTestBot BrewTestBot deleted the bump-wxwidgets-3.3.1 branch July 22, 2025 12:56
carlocab added a commit that referenced this pull request Jul 22, 2025
This is needed after #230768. This wasn't done in that PR since
`erlang@24` is deprecated, and will be disabled in 2 days.

Let's update it anyway since it's relatively straightforward to do, and
ensures that `brew extract` works properly even after this is disabled.
carlocab added a commit that referenced this pull request Jul 22, 2025
This is needed after #230768. This wasn't done in that PR since
`erlang@24` is deprecated, and will be disabled in 2 days.

Let's update it anyway since it's relatively straightforward to do, and
ensures that `brew extract` works properly even after this is disabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alias bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants