Skip to content

Fix #55: Use click event for all devices #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Daniel-Hug wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #55: Use click event for all devices #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/css/select-theme-chosen.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ $mobileBreakPointSize: ($maxRows + 4) * $optionHeight
+inline-block
+user-select(none)
+no-mobile-tap-highlight
touch-action: manipulation;
border-radius: 5px
box-shadow: 0 0 3px #FFF inset, 0 1px 1px rgba(0, 0, 0, 0.1)
background-image: linear-gradient(to bottom, #ffffff 20%, #f6f6f6 50%, #eeeeee 52%, #f4f4f4 100%)
Expand Down
1 change: 1 addition & 0 deletions src/css/select-theme-dark.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ $mobileBreakPointSize: ($maxRows + 4) * $optionHeight
+inline-block
+user-select(none)
+no-mobile-tap-highlight
touch-action: manipulation;
border-radius: .25em
position: relative
padding: $paddingTopBottom 3em $paddingTopBottom 1em
Expand Down
1 change: 1 addition & 0 deletions src/css/select-theme-default.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ $mobileBreakPointSize: ($maxRows + 4) * $optionHeight
+inline-block
+user-select(none)
+no-mobile-tap-highlight
touch-action: manipulation;
border-radius: .25em
position: relative
padding: $paddingTopBottom 3em $paddingTopBottom 1em
Expand Down
7 changes: 2 additions & 5 deletions src/js/select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ const SPACE = 32;
const UP = 38;
const DOWN = 40;

const touchDevice = 'ontouchstart' in document.documentElement;
const clickEvent = touchDevice ? 'touchstart' : 'click';

function useNative() {
const {innerWidth, innerHeight} = window;
return touchDevice && (innerWidth <= 640 || innerHeight <= 640);
Expand Down Expand Up @@ -303,12 +300,12 @@ class Select extends Evented {
}

bindClick() {
this.target.addEventListener(clickEvent, (e) => {
this.target.addEventListener('click', (e) => {
e.preventDefault();
this.toggle();
});

document.addEventListener(clickEvent, (event) => {
document.addEventListener('click', (event) => {
if (!this.isOpen()) {
return;
}
Expand Down