-
Notifications
You must be signed in to change notification settings - Fork 33
Added genetic diversity fields - Fixes #1610 #1611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Changes from 19 commits
6640701
1615c72
7dd118b
f75abbd
d56461e
3b37ae4
7049d18
836c795
078808e
af5cc71
b47e9d0
697794d
9e47276
0773d49
e6eae2d
ad34acf
19c68b3
e359985
e25686d
a16c5e4
32d999a
6717c3c
dc1ef4e
a9056e0
e8f4a70
d9bcedc
e60820b
5f4b27f
cbca404
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -2,6 +2,11 @@ | |||||||||
"$schema": "http://json-schema.org/draft-07/schema#", | ||||||||||
"description": "Information specific to a donor that is a human (Homo sapiens).", | ||||||||||
"additionalProperties": false, | ||||||||||
"dependencies": { | ||||||||||
"ethnicity_question": [ | ||||||||||
"ethnicity" | ||||||||||
] | ||||||||||
}, | ||||||||||
"title": "Human-specific", | ||||||||||
"name": "human_specific", | ||||||||||
"type": "object", | ||||||||||
|
@@ -33,6 +38,117 @@ | |||||||||
}, | ||||||||||
"user_friendly": "Ethnicity", | ||||||||||
"guidelines": "Enter one or more ethnicities, separated by a comma." | ||||||||||
}, | ||||||||||
"ethnicity_question": { | ||||||||||
hannes-ucsc marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||
"description": "Question and response options posed to donors for collecting metadata on donor self-reported ethnicity and / or tribe and / or dialect group and / or race etc.", | ||||||||||
"type": "string", | ||||||||||
"user_friendly": "Ethnicity question", | ||||||||||
"example": "What is your ethnicity?; Are you Hispanic/Latino?; Which categories describe you? Select all that apply. Note You may select more than one group. 1. American Indian or Alaska Native (for example, Aztec, Blackfeet Tribe, Mayan, Navajo Nation, Native Village of Barrow (Utqiagvik) Inupiat Traditional Government, Nome Eskimo Community, etc.), 2 - Asian (for example, Asian Indian, Chinese, Filipino, Japanese, Korean, Vietnamese, etc.), 3 - Black, African American, or African (for example, African American, Ethiopian, Haitian, Jamaican, Nigerian, Somali, etc.), 4 - Hispanic, Latino, or Spanish (for example, Columbian, Cuban, Dominican, Mexican or Mexican American, Puerto Rican, Salvadoran, etc.), 5 - Middle Eastern or North African (for example, Algerian, Egyptian, Iranian, Lebanese, Moroccan, Syrian, etc.), 6 - Native Hawaiian or other Pacific Islander (for example, Chamorro, Fijian, Marshallese, Native Hawaiian, Tongan, etc.), 7 - White (for example, English, European, French, German, Irish, Italian, Polish, etc.), 8 - None of these fully describe me (optional free text answer), 9 - Prefer not to answer", | ||||||||||
"bionetworks": ["genetic diversity"] | ||||||||||
}, | ||||||||||
"ethnicity_parents": { | ||||||||||
|
"ethnicity_parents": { | |
"parental_ethnicities": { |
Just a suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, in line with my comment below
"ethnicity_parents": { | |
"ethnicity_of_parents": { |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"mother_father_language": { | |
"first_language": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the Taskforce guidelines, this is about the language that the donor parents speak. Not necessarily the first language the donor spoke.
Maybe we could revert to parents_language
to distinguish between "first language" and "language of mother".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this PR, this field is currently documented as
Ancestral language(s), spoken by parents (“mother tongue” and / or “father tongue”) and / or grandparents. Can include dialects (for example, Hokkien).
"Mother tongue" typically means one's native language, not the language spoken by one's mother. To avoid confusion, I would prefer we avoid the terms "mother/father tongue" completely. "Ancestral language" usually means the opposite of modern language. I would also avoid that.
As for the name of the property, I propose that we establish a convention for naming properties of immediate ancestors (parents) or ancestors in general. Prefixing the property name with parental_
or ancestral_
comes to mind but then the aforementioned ambiguity arises. Since it is not possible to include an apostrophe in a property name, I wouldn't use "parents_" as that could be the plural "parents" or a possessive "parent's".
My preferred choice would be the suffix "_of_parents" and "_of_ancestors", applied to all such properties across this PR. I would include great grand parents in this property as it seems arbitrary to draw the line above the grand parents.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,18 @@ | ||
Schema,Change type,Change message,Version,Date | ||
module/biomaterial/human_specific,minor,Added optional ethnicity_question,, | ||
module/biomaterial/human_specific,minor,Added optional ethnicity_parents,, | ||
module/biomaterial/human_specific,minor,Added optional primary_language,, | ||
module/biomaterial/human_specific,minor,Added optional mother_father_language,, | ||
module/biomaterial/human_specific,minor,Added optional current_residence_location_country,, | ||
module/biomaterial/human_specific,minor,Added optional current_residence_location_granular,, | ||
module/biomaterial/human_specific,minor,Added optional current_residence_duration,, | ||
module/biomaterial/human_specific,minor,Added optional current_residence_urbanrural,, | ||
module/biomaterial/human_specific,minor,Added optional place_of_birth_location_country,, | ||
module/biomaterial/human_specific,minor,Added optional place_of_birth_location_granular,, | ||
module/biomaterial/human_specific,minor,Added optional place_of_birth_duration,, | ||
module/biomaterial/human_specific,minor,Added optional place_of_birth_urbanrural,, | ||
module/biomaterial/medical_history,minor,Added optional diet_meat_consumption,, | ||
module/biomaterial/medical_history,minor,Added optional menarche_age,, | ||
module/biomaterial/medical_history,minor,Added optional menopause_status,, | ||
module/biomaterial/medical_history,minor,Added optional parity,, | ||
module/biomaterial/medical_history,minor,Added optional gravidity,, |
Uh oh!
There was an error while loading. Please reload this page.