-
Notifications
You must be signed in to change notification settings - Fork 93
fix(ibm-major-version-in-path): extend rule to check major version is the first segment #766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments, otherwise it looks good!
Update: please use a bit more descriptive commit message when merging this PR. Something like
fix(ibm-major-version-in-path): extend rule to check major version is the first segment
should be fine.
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
pyrooka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
## @ibm-cloud/openapi-ruleset [1.33.2](https://github.com/IBM/openapi-validator/compare/@ibm-cloud/openapi-ruleset@1.33.1...@ibm-cloud/openapi-ruleset@1.33.2) (2025-10-27) ### Bug Fixes * **ibm-major-version-in-path:** extend rule to check major version is the first segment ([#766](#766)) ([ed61873](ed61873))
|
🎉 This PR is included in version 1.33.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.37.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Extends the ibm-major-version-in-path rule so it validates that the version number is the first segment of the API's path if the version number is located in the path.
PR Checklist
General checklist
Please make sure that your PR fulfills the following requirements:
.secrets.baselinehas been updated as needednpm run update-utilitieshas been run if any files inpackages/utilities/srchave been updatedChecklist for adding a new validation rule: