Dependency cleanup using depcheck

[J-ratio]

Dependency cleanup for libms service using depcheck

Type of Change

• New feature
• Bug fix
• Documentation update
• Refactoring
• Security patch
• UI/UX improvement

Description

Removed Unused Dependencies:

1. type-graphql - It was redundant with @nestjs/graphql
2. mock-fs - It wasn't directly used in the codebase
3. react - Found no direct references in main/test code for this backend service
4. graphql-scalars - After thorough analysis, confirmed it wasn't being used

Added Missing Dependencies:

1. eslint/js - Required by eslint.config.js
2. @jest/globals - Used in test files

Testing

Ran the following tests:

Unit tests: 22 tests PASSED
Integration tests: All PASSED
End-to-End tests: All PASSED

Impact

Cleans up stray dependencies and adds missing dependencies for better maintenance of the project.

Additional Information

Analysis Report:

Depcheck Output

Unused dependencies

@apollo/server
@nestjs/platform-express
graphql
mock-fs
reflect-metadata
rxjs
type-graphql

Unused Dev Dependencies

@nestjs/cli
@nestjs/schematics
@types/express
eslint
eslint-config-airbnb-base
eslint-plugin-prettier
graphql-scalars
jest
prettier
react
ts-node
tsconfig-paths
typescript

Missing Dependencies

@eslint/js: ./eslint.config.js
src: ./test/testUtil.ts
@jest/globals: ./test/testUtil.ts
test: ./test/unit/files-service.factory.unit.spec.ts

Detailed Analysis of Flagged Dependencies:

1. mock-fs - POTENTIALLY REMOVABLE

Looking through the codebase, I don't see direct usage of this package.

2. reflect-metadata - FALSE POSITIVE

Critical dependency for NestJS's decorator-based metadata reflection system.
Required for all decorators used in the code (like @Injectable(), @resolver(), etc.)

3. rxjs - FALSE POSITIVE

Core dependency for NestJS's internal event handling and reactive programming features.
NestJS uses RxJS observables extensively under the hood.

4. type-graphql - POTENTIALLY REDUNDANT

@nestjs/graphql provides similar functionality integrated into NestJS.
The code uses @nestjs/graphql decorators instead of type-graphql's.

5. graphql-scalars - POTENTIALLY REMOVABLE

No clear evidence of direct usage in the code.

6. jest - FALSE POSITIVE

Used extensively in test scripts and configurations.

7. react - LIKELY REMOVABLE

Unusual dependency for a backend service.
No evidence of React usage in the libms microservice code.
May have been added accidentally or for a specific test case?

11. ts-node - FALSE POSITIVE

Used for running TypeScript files directly without pre-compilation.

12. @eslint/js - SHOULD BE ADDED

Used in eslint.config.js but missing from dependencies.

13. @jest/globals - SHOULD BE ADDED

Used in test files but missing from dependencies.

Checklist

• My code adheres to the coding and style guidelines of the project.
• I have added tests for all the new code and any changes made to
  existing code.
• I have made corresponding changes to the documentation.

[J-ratio]

@prasadtalasila created a draft PR for cleaning up some unused dependencies i found during depcheck of libms service,
also do let me know if added dependencies are not redundant as they were flagged as missing

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.95%. Comparing base (664266b) to head (9f6d011).

❗ There is a different number of reports uploaded between BASE (664266b) and HEAD (9f6d011). Click for more details.

HEAD has 2 uploads less than BASE

Flag	BASE (664266b)	HEAD (9f6d011)
client-unit-integration-tests	2	0

Additional details and impacted files

@@                     Coverage Diff                      @@
##           feature/distributed-demo   #1250       +/-   ##
============================================================
- Coverage                     92.08%   2.95%   -89.13%     
============================================================
  Files                            92      15       -77     
  Lines                          2526     169     -2357     
  Branches                        406       9      -397     
============================================================
- Hits                           2326       5     -2321     
+ Misses                          197     164       -33     
+ Partials                          3       0        -3     

see 107 files with indirect coverage changes

Components	Coverage Δ
Website	∅ <ø> (∅)
Lib Microservice	2.95% <ø> (∅)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[prasadtalasila]

@J-ratio Thanks for the PR. The changes look good.
I suggest upgrading all the npm dependencies to their latest versions. The goal is to aggressively upgrade versions of all npm packages included in the package.json. For example, commit 8313de1 upgrades npm packages of libms.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud