-
Notifications
You must be signed in to change notification settings - Fork 530
Prevent ExcludeEmailFromExport to hide the user email when an authorized user is obtaining metadata for editing a dataset #11819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stevenwinship
wants to merge
20
commits into
develop
Choose a base branch
from
11714-prevent-exclude-email-from-export-for-permitted-user-get-dataset-version
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+119
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
…or-permitted-user-get-dataset-version
This comment has been minimized.
This comment has been minimized.
…or-permitted-user-get-dataset-version
This comment has been minimized.
This comment has been minimized.
…or-permitted-user-get-dataset-version
…or-permitted-user-get-dataset-version
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
…or-permitted-user-get-dataset-version
This comment has been minimized.
This comment has been minimized.
…or-permitted-user-get-dataset-version
This comment has been minimized.
This comment has been minimized.
qqmyers
approved these changes
Oct 24, 2025
Member
qqmyers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - nice improvement to the DatasetFieldWalker!
…or-permitted-user-get-dataset-version
This comment has been minimized.
This comment has been minimized.
…or-permitted-user-get-dataset-version
This comment has been minimized.
This comment has been minimized.
…or-permitted-user-get-dataset-version
This comment has been minimized.
This comment has been minimized.
…or-permitted-user-get-dataset-version
This comment has been minimized.
This comment has been minimized.
…or-permitted-user-get-dataset-version
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY26 Sprint 4
FY26 Sprint 4 (2025-08-13 - 2025-08-27)
FY26 Sprint 5
FY26 Sprint 5 (2025-08-27 - 2025-09-10)
FY26 Sprint 6
FY26 Sprint 6 (2025-09-10 - 2025-09-24)
FY26 Sprint 7
FY26 Sprint 7 (2025-09-24 - 2025-10-08)
FY26 Sprint 8
FY26 Sprint 8 (2025-10-08 - 2025-10-22)
FY26 Sprint 9
FY26 Sprint 9 (2025-10-22 - 2025-11-05)
FY26 Sprint 10
FY26 Sprint 10 (2025-11-05 - 2025-11-19)
FY26 Sprint 11
FY26 Sprint 11 (2025-11-20 - 2025-12-03)
FY26 Sprint 12
FY26 Sprint 12 (2025-12-03 - 2025-12-17)
FY26 Sprint 14
FY26 Sprint 14 (2025-12-31 - 2026-01-14)
GREI Re-arch
Issues related to the GREI Dataverse rearchitecture
Original size: 10
Size: 10
A percentage of a sprint. 7 hours.
SPA.Q3.2025
Not related to any specific Q3 2025 feature
SPA
These changes are required for the Dataverse SPA
Type: Feature
a feature request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: SPA needs to get the contact email to fill the edit screen even when the ExcludeEmailFromExport setting is set. Only for users calling the get dataset version API and the user has EditDataset permissions.
Which issue(s) this PR closes:#11714
Special notes for your reviewer:
Suggestions on how to test this: See DatasetIT test
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation: