Skip to content

Resolved issue #1 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbhinavHaridas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Resolved issue #1 #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Day 1/skybox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,14 @@ function init(){
let skyBox = new THREE.Mesh(skyBoxGeo, materialArray); //Mesh requires

scene.add(skyBox);
window.addEventListener('resize', ()=>{window.location.reload()});
// In the resize event handler, you are reloading the entire page when the window is resized.
// This approach may cause unnecessary resource reloads and reinitialization. Instead, consider updating the camera and
// renderer aspect ratio directly without reloading the whole page
window.addEventListener('resize', () => {
camera.aspect = window.innerWidth / window.innerHeight;
camera.updateProjectionMatrix();
renderer.setSize(window.innerWidth, window.innerHeight);
});
}
function animate() {

Expand Down