Skip to content

Let ipv4-or-ipv6 prefer IPv6 instead of ipv4 #10500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RincewindsHat
Copy link
Member

Previously the magical "ipv4-or-ipv6" CheckCommand template preferred the IPv4 address (address field of a Host object) to the IPv6 address (address6 field of a Host object).

This commit reverses the behaviour to favor IPv6 as it is common among different applications in order to further the transition to IPv6.

This is a breakout PR related to #10494 where the idea originated.

Practically speaking this change will not affect many setups, since the
common enterprise network setup still relies on legacy IP only.
For some setups with dual-stack though this will change the behaviour quite
suddenly although the impact should be inconsiderable and go unnoticed
if the the network setup was done properly.

Previously the magical "ipv4-or-ipv6" CheckCommand template
preferred the IPv4 address (`address` field of a Host object)
to the IPv6 address (`address6` field of a Host object).

This commit reverses the behaviour to favor IPv6 as it is
common among different applications in order to further the
transition to IPv6.
@cla-bot cla-bot bot added the cla/signed label Jul 9, 2025
@oxzi oxzi added the area/itl Template Library CheckCommands label Jul 9, 2025
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As written over in the original PR, I am in favor for this change, reflecting the IETF's preference for IPv6 as also stated in RFC 8305. Since there are the $check_ipv4$ and $check_ipv6$ macros being set by multiple CheckCommands with an additional -4 or -6 argument, there should be no harm.

On the other hand, the current version works and just changing the behavior because one likes IPv6 better is a poor argument.

Thus, I would like to another opinion on this change.

@Al2Klimov Al2Klimov added this to the 2.16.0 milestone Jul 10, 2025
@julianbrost
Copy link
Contributor

IMHO there's no real benefit from this change. It just risks breaking existing configurations.

If you want that behavior, you already have the option of setting the check_ipv6 variable.

This commit reverses the behaviour to favor IPv6 as it is common among different applications in order to further the transition to IPv6.

No it doesn't as it requires that there was already an address6 set.

@julianbrost julianbrost removed this from the 2.16.0 milestone Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/itl Template Library CheckCommands cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants