feat(tooltip): add show/hide triggers #16422
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RivaIvanova
added
🛠️ status: in-development
…into rivanova/tooltip-show-hide-triggers
RivaIvanova
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds configurable show/hide triggers for tooltips, replacing the previous mouse/touch event-based system with a more flexible event-driven approach.
- Introduces
showTriggersandhideTriggersproperties toIgxTooltipTargetfor custom event configuration - Replaces mouse events (
mouseenter/mouseleave) with pointer events (pointerenter/pointerleave) as the new default triggers - Removes touch-specific event handling in favor of the generic trigger system
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tooltip-target.directive.ts | Adds showTriggers/hideTriggers properties with dynamic event listener management using AbortController |
| tooltip.directive.ts | Simplifies by removing constructor and touch event handling, updates to use pointer events |
| tooltip.common.ts | Adds parseTriggers utility function and regex pattern for parsing trigger strings |
| tooltip.directive.spec.ts | Updates tests to use new trigger system, replaces touch tests with generic trigger tests |
| grid-validation.spec.ts | Updates test from mouseenter to pointerenter event |
| README.md | Documents new showTriggers and hideTriggers properties |
| CHANGELOG.md | Adds entry for new tooltip trigger features in version 20.2.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
projects/igniteui-angular/src/lib/directives/tooltip/tooltip-target.directive.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/directives/tooltip/tooltip-target.directive.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16336
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)