Fix window hovered and UTF decode issues #829
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelSharp
force-pushed
the
fix-hovered-unicode4
branch
from
1586bdd to
75a8d9b
Compare
…ng state in nk_window_is_hovered fix: allow len == NK_UTF_SIZE in nk_utf_decode by adjusting NK_BETWEEN upper bound
PavelSharp
force-pushed
the
fix-hovered-unicode4
branch
from
75a8d9b to
c2f210a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains two independent fixes:
[BUG]
nk_window_is_hoveredusesctx->begininstead ofctx->current#827nk_window_is_hovered:Check
NK_WINDOW_MINIMIZEDusingctx->current->flagsinstead ofctx->begin->flagsto correctly detect minimized windows. See
nk_utf_decode:Adjust
NK_BETWEENupper bound toNK_UTF_SIZE+1to allow full valid UTF sequence lengths.