Skip to content

Correctly handle hover in popup windows #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correctly handle hover in popup windows #837

wants to merge 1 commit into from
+6 −3

Conversation

lockie
Copy link
Contributor

@lockie lockie commented Oct 10, 2025

Hello! Right now nk_widget_is_hovered and its mouse friends nk_widget_mouse_clicked and nk_widget_has_mouse_click_down do not work for popup windows, always returning 0. This PR fixes that by making exception to always look inside the windows with NK_PANEL_SET_POPUP layout type.

lockie added a commit to lockie/cl-liballegro-nuklear that referenced this pull request Oct 10, 2025
@lockie
applied hover in popup patch
db29fc2 
see Immediate-Mode-UI/Nuklear#837
RobLoach
RobLoach approved these changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Thanks a lot for pushing this forwards.

RobLoach
RobLoach requested changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we'll have to make this change in the src file before it makes its way into nuklear.h. Mind fixing it there as well?

RafaDEV99
RafaDEV99 approved these changes Oct 17, 2025
View reviewed changes
Copy link

@RafaDEV99 RafaDEV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is very Good! However, as noted by @RobLoach, it first needs to be pushed to the src file (i.e., src/nuklear.c).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobLoach RobLoach RobLoach requested changes

+1 more reviewer

@RafaDEV99 RafaDEV99 RafaDEV99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lockie @RobLoach @RafaDEV99