-
Notifications
You must be signed in to change notification settings - Fork 202
Mindmap screenshot with pageres-cli #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The screenshot generation works now. However the "Commit Changes" step does not work, as multiple matrix builds are trying changing the state of the repository in parallel. The git-auto-commit-action GHA explicitly mentions this limitation. One way to solve this would be to upload the screenshots as artefacts in the matrix build, then at the end have a single job that downloads all artefacts and commits them. See stefanzweifel/git-auto-commit-action#290 and https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/run-job-variations#using-an-output-to-define-two-matrices |
…by these jobs don't collide with each other
|
I tried a configuration where only one job of this workflow can run at the same time. i.e. switching off concurrency for this workflow entirely. However even then it returns an error: |
…/add-and-commit@v9
|
Since f4ad3fb the execution is working. All jobs of the matrix build are running sequentially now (aside: the whole Each of these jobs takes 30sec though, so in total the workflow takes 2 minutes, which is quite long. I am considering to put it all in a single script that loops over all folders below "pattern-categorization" and calls the required clis to generate the markmap, take the screenshot, etc. |
|
YES, finally! Instead of using a GHA matrix build, I ended up with this approach:
|
Fixes #570. (or at least tries to ... again ;))
I am trying again to fix the GHA workflow that takes a screenshot of the mindmap that is rendered in our online book.
Previous failed tries were #571 and #775.
Found this here that can take screenshots on the CLI:
https://github.com/sindresorhus/pageres-cli
Could not find a GHA that wraps this but it was easy enough to express this in a workflow myself.
TODO: