BUG: Boundary condition was not propagated to FFTPadPositiveIndex #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phcerdan
changed the title
|
@phcerdan Tested just now, and the SHA-512 hash is exactly the same for the three of them again. I guess that's perfectly legal (@thewtex, @fbudin69500 please correct me if I'm wrong; i.e. depending on the input image, i.e. which are the values at the image boundaries to be used when padding? If that is correct, then the result is fine and no issue exists; if we really want to test the effect of a given padding/neighborhood because that is interesting for the current context, then we should add another test image. |
|
I haven't looked on the test images, but depending on their size, padding may not be required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised by @jhlegarreta at PR #48 and issue #36
The
SetBoundaryConditionin the class wasn't propagating that boundary to the m_FFTPad which uses it.Also... I modified GenerateInputRequestedRegion to have into account the shift that we apply to the output (after the regular FFTPad).
@jhlegarreta maybe now the tests produce different outputs?