- 
                Notifications
    You must be signed in to change notification settings 
- Fork 70
ENH: add SmoothImageWithDiscreteGaussianFilter python example #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ENH: add SmoothImageWithDiscreteGaussianFilter python example #372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! Please see comments for Pythonic equivalents of ITK filters.
        
          
                src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/Code.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RomanFenioux well done!!
CI is failing because it expects an image for the test.
Exception detected while reading /home/runner/work/bld/ITKEx-build/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilterPython.png : 
itk::ImageFileReaderException (0x5594a8e5f4d0)
Location: "unknown" 
File: /home/runner/work/bld/ITK/Modules/IO/ImageBase/include/itkImageFileReader.hxx
Line: 132
Description:  Could not create IO object for reading file /home/runner/work/bld/ITKEx-build/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilterPython.png
The file doesn't exist. 
Filename = /home/runner/work/bld/ITKEx-build/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilterPython.png
Exception detected while reading /home/runner/work/bld/ITKEx-build/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilterPython.png : 
itk::ImageFileReaderException (0x5594a8e5d740)
Location: "unknown" 
File: /home/runner/work/bld/ITK/Modules/IO/ImageBase/include/itkImageFileReader.hxx
Line: 132
Description:  Could not create IO object for reading file /home/runner/work/bld/ITKEx-build/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilterPython.png
The file doesn't exist. 
Filename = /home/runner/work/bld/ITKEx-build/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilterPython.png
For more information on how to add this image, please see the other examples and the documentation here: https://examples.itk.org/documentation/contribute/uploadbinarydata
| Hi @thewtex | 
| Hi @RomanFenioux looking great! Could you please rebase on  | 
43ae8c1    to
    afa5c63      
    Compare
  
    
No description provided.