Skip to content

Add implementation of dpnp.frexp #2635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Add implementation of dpnp.frexp #2635

wants to merge 21 commits into from
+1,903 −129

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Oct 23, 2025 •
edited
Loading

The PR adds the implementation of dpnp.frexp and extends the framework to support a unary function with two output arrays, including new wrappers in ufunc pybind11 extension and new python class DPNPUnaryTwoOutputsFunc.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Oct 23, 2025
@antonwolfy antonwolfy self-assigned this Oct 23, 2025
@github-actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2635/index.html

@coveralls
Copy link
Collaborator

coveralls commented Oct 23, 2025 •
edited
Loading

Coverage Status

coverage: 83.164% (-0.1%) from 83.312%
when pulling fe2fea1 on impl-frexp
into 9f9b906 on master.

@antonwolfy antonwolfy force-pushed the impl-frexp branch 3 times, most recently from d666152 to 65f3d15 Compare October 27, 2025 11:19
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_41 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@antonwolfy
Extend _result_typeid() utility ufunc function to template the mappin…
6b18f66 
…g table
@antonwolfy
Remove unnecessary import in ldexp.cpp
6114e74
@antonwolfy
Declare namespace in correct scope in fmod.cpp
e7f4097
@antonwolfy
Add unary implementation for ufunc with two output arrays
fdd8fff
@antonwolfy
Move definition of _result_typeid to the header to avoid undefined re…
f6e2d4e 
…ference issue
@antonwolfy
Extend type_dispatch namespace with TypeMapTwoResultsEntry and Defaul…
b67f8d9 
…tTwoResultsEntry
@antonwolfy
Extend dpctl::tensor::kernels::elementwise_common namespace with supp…
eacd7d0 
…ort of two output arrays
@antonwolfy
Add frexp implementation to ufunc extension
36a1b38
@antonwolfy
Add DPNPUnaryTwoOutputsFunc class for unary element-wise functions wi…
2eb264b 
…th two output arrays
@antonwolfy
Add python implementation
b1ac175
@antonwolfy
Enable umath and third party tests
0b93ff8
@antonwolfy
Add CFD tests
b2eca3c
@antonwolfy
Add tests to cover frexp and new class
52948bd
@antonwolfy
Add PR to the changelog
6b81a2a
@antonwolfy
Add more tests to improve the coverage
b2e0966
@antonwolfy
Run test_strides_out only with Linux due to platform dependant result…
bb67c61 
… returned by numpy.frexp
@antonwolfy
Update test_empty to test exactly empty input array
477f418
@antonwolfy
Fix TestFrexp::test_basic to work with unsigned dtype
78ab745
@antonwolfy
Peremetrize dtype of the out in TestFrexp::test_out
5e4da80
@antonwolfy
Align signature of rendered docuemntation for dpnp.frexp
de8245b
@antonwolfy
Add description of out keyword
fe2fea1
@antonwolfy antonwolfy marked this pull request as ready for review October 28, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

0.20.0 release

Development

Successfully merging this pull request may close these issues.

2 participants

@antonwolfy @coveralls