increament send / recv EngineOutput in ray mp engine #4048
+33
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grimoire
reviewed
Oct 17, 2025
| # ray generator would try cache every result, which is too verbose. | ||
| stream_id = await self._collective_rpc_async('create_stream_task', func, *args, **kwargs) | ||
|
|
||
| def __handle_logprobs(result): |
There was a problem hiding this comment.
could we handle it here?
grimoire
reviewed
Oct 17, 2025
lmdeploy/pytorch/engine/engine.py
Outdated
| cur_logprobs = dict(zip(indices, vals)) | ||
| logprobs = [] if out.resp.data is None else out.resp.data.get('logprobs', []) | ||
| logprobs = logprobs + [cur_logprobs] | ||
| if self.engine_config.mp_engine_backend == 'ray': # how to check enable_mp_engine? |
There was a problem hiding this comment.
We could define a new mp_engine_backend indicates that the engine is inside an mp_engine.
|
I tried using |
irexyc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist