Refactor EPOCH into more conceptually related modules #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 23, 2025
carlostome
commented
Oct 23, 2025
williamdemeo
approved these changes
Oct 24, 2025
src/Ledger/Conway/Specification/Epoch/Properties/Computational.agda
Outdated
Show resolved
Hide resolved
src/Ledger/Conway/Specification/Epoch/Properties/Computational.agda
Outdated
Show resolved
Hide resolved
src/Ledger/Conway/Specification/Epoch/Properties/Computational.agda
Outdated
Show resolved
Hide resolved
src/Ledger/Conway/Specification/Epoch/Properties/Computational.agda
Outdated
Show resolved
Hide resolved
src/Ledger/Conway/Specification/Epoch/Properties/Computational.agda
Outdated
Show resolved
Hide resolved
| Γ : RatifyEnv | ||
| Γ = ⟦ stakeDistrs , e , DRepsOf ls , CCHotKeysOf ls , TreasuryOf acnt , PoolsOf ls , VoteDelegsOf ls ⟧ | ||
| Γ = ⟦ stakeDistrs , e , DRepsOf ls , CCHotKeysOf ls , TreasuryOf acnt'' , PoolsOf ls , VoteDelegsOf ls ⟧ |
There was a problem hiding this comment.
The improved organization is helpful, but tbh, I still think it's hard to tell whether no prime, single prime, or double prime is correct in each case. Part of the problem, imho, is the use of private variables for things like ls and fut and fut'. In situations like this, with tons of variables floating around, private variables have an "appear as if from nowhere" vibe.
Co-authored-by: William DeMeo <williamdemeo@gmail.com>
carlostome
force-pushed
the
carlos/refactor-epoch
branch
from
c43bc92 to
6fddcb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the EPOCHUpdates modules used in the EPOCH transition system in smaller bits.
In particular, it does so around those updates which occur before the POOLREAP transition system and after.
It subsumes the changes to EPOCH in #941.
It subsumes the change to Acnt in #961 (and hence closes #960).
Checklist
CHANGELOG.md