Skip to content

ready: eslint deps are devDependencies #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alex-a-pereira wants to merge 2 commits into from
Closed

ready: eslint deps are devDependencies #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6544aa
fix: move eslint deps to devDependencies obj
alex-a-pereira Nov 1, 2024
71809be
feat: bump version and add changelog
alex-a-pereira Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.3.21
## Fixes
- Moves lint dependencies into `devDependencies` so that consumers who use `yarn` will not see warnings when installing.

## 1.3.20
## Fixes
- Fixes an issue where the iOS SDK incorrectly targeted the latest minor version instead of a fixed version, potentially causing breaking changes.
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ For quick reference, the following table lists the versions of the [Android SDK]

| RN SDK Version | Android SDK Version | iOS SDK Version |
| --------------------------------------------------------------------------- | ---------------------------------------------------------------------------- | --------------- |
| [1.3.21](https://www.npmjs.com/package/@iterable/react-native-sdk/v/1.3.21) | [3.5.2](https://github.com/Iterable/iterable-android-sdk/releases/tag/3.5.2) | [6.5.4](https://github.com/Iterable/swift-sdk/releases/tag/6.5.4)
| [1.3.20](https://www.npmjs.com/package/@iterable/react-native-sdk/v/1.3.20) | [3.5.2](https://github.com/Iterable/iterable-android-sdk/releases/tag/3.5.2) | [6.5.4](https://github.com/Iterable/swift-sdk/releases/tag/6.5.4)
| [1.3.19](https://www.npmjs.com/package/@iterable/react-native-sdk/v/1.3.19) | [3.5.2](https://github.com/Iterable/iterable-android-sdk/releases/tag/3.5.2) | [6.5.3](https://github.com/Iterable/swift-sdk/releases/tag/6.5.3)
| [1.3.18](https://www.npmjs.com/package/@iterable/react-native-sdk/v/1.3.18) | [3.5.2](https://github.com/Iterable/iterable-android-sdk/releases/tag/3.5.2) | [6.5.3](https://github.com/Iterable/swift-sdk/releases/tag/6.5.3)
Expand Down
2 changes: 1 addition & 1 deletion SampleApp/javascript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"lint": "eslint ."
},
"dependencies": {
"@iterable/react-native-sdk": "^1.3.20",
"@iterable/react-native-sdk": "^1.3.21",
"@react-native-community/masked-view": "^0.1.10",
"@react-native-community/toolbar-android": "^0.1.0-rc.2",
"@react-navigation/bottom-tabs": "^5.4.5",
Expand Down
2 changes: 1 addition & 1 deletion SampleApp/typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"lint": "eslint ."
},
"dependencies": {
"@iterable/react-native-sdk": "^1.3.20",
"@iterable/react-native-sdk": "^1.3.21",
"@react-native-community/masked-view": "^0.1.10",
"@react-native-community/toolbar-android": "^0.1.0-rc.2",
"@react-navigation/bottom-tabs": "^5.4.5",
Expand Down
2 changes: 1 addition & 1 deletion integration-testing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"e2e:android-release": "npm run build:android-release && npm run test:android-release"
},
"dependencies": {
"@iterable/react-native-sdk": "^1.3.20",
"@iterable/react-native-sdk": "^1.3.21",
"@react-native-community/masked-view": "^0.1.10",
"@react-navigation/bottom-tabs": "^5.4.5",
"@react-navigation/native": "^5.4.0",
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@iterable/react-native-sdk",
"version": "1.3.20",
"version": "1.3.21",
"description": "Iterable SDK for React Native.",
"main": "./js/index.js",
"types": "./js/index.d.ts",
Expand All @@ -23,8 +23,6 @@
"dependencies": {
"@react-native-community/hooks": "^2.6.0",
"@react-navigation/native": "^6.0.6",
"eslint": "^8.0.1",
"eslint-config-airbnb": "^19.0.4",
"react-native-safe-area-context": "^4.1.2",
"react-native-vector-icons": "^9.0.0",
"react-native-webview": "^11.0.0"
Expand All @@ -38,6 +36,8 @@
"@types/react-native-vector-icons": "^6.4.10",
"@types/react-test-renderer": "^17.0.1",
"@typescript-eslint/eslint-plugin": "^5.0.0",
"eslint": "8.57.1",
"eslint-config-airbnb": "^19.0.4",
"eslint-config-standard": "^14.0.0",
"eslint-config-standard-jsx": "^8.1.0",
"eslint-config-standard-react": "^9.2.0",
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3222,7 +3222,7 @@ eslint-visitor-keys@^3.3.0, eslint-visitor-keys@^3.4.1, eslint-visitor-keys@^3.4
resolved "https://registry.yarnpkg.com/eslint-visitor-keys/-/eslint-visitor-keys-3.4.3.tgz#0cd72fe8550e3c2eae156a96a4dddcd1c8ac5800"
integrity sha512-wpc+LXeiyiisxPlEkUzU6svyS1frIO3Mgxj1fdy7Pm8Ygzguax2N3Fa/D/ag1WqbOprdI+uY6wMUl8/a2G+iag==

eslint@^8.0.1:
eslint@8.57.1:
version "8.57.1"
resolved "https://registry.yarnpkg.com/eslint/-/eslint-8.57.1.tgz#7df109654aba7e3bbe5c8eae533c5e461d3c6ca9"
integrity sha512-ypowyDxpVSYpkXr9WPv2PAZCtNip1Mv5KTW0SCurXv/9iOpcrH9PaqUElksqEB6pChqHGDRCFTyrZlGhnLNGiA==
Expand Down
Loading