Skip to content

Conversation

@johnhaup
Copy link
Contributor

✏️ Description

Using the UI components (example: Inbox) breaks because react navigation and safe area context are dependencies in the SDK, so they get installed in the package's own node_modules (node_modules/@iterable/react-native-sdk/node_modules). The makes the components look for navigation context and safe area context from an instance in its own node_modules, instead of the consumer's project.

  • Removed react-hooks package (unused in SDK)
  • Moved lint packages from dependencies to devDependencies
  • Moved packages from dependencies to peerDependencies, using major versions as minimum

@lposen
Copy link
Contributor

lposen commented Nov 15, 2024

Approved. Looks good to me.

@johnhaup
Copy link
Contributor Author

This also address #596

@lposen lposen merged commit ce3309d into Iterable:master Nov 25, 2024
2 of 4 checks passed
@ghost
Copy link

ghost commented Dec 10, 2024

@lposen @johnhaup exciting change. I'd love to incorporate this into my project because I'm looking to upgrade react-native-safe-area-context from v4 to v5 and this change will allow me to avoid having two versions installed or needing to add a manual resolution to the version of my choosing.

Can you let me know if this will be available in a new release soon (ie this week) or not?

@alex-a-pereira
Copy link
Contributor

thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants