Skip to content

Conversation

lposen and others added 30 commits August 1, 2025 14:05
…ew-arch/MOB-11828-add-backwards-compatibility
…ew-arch/MOB-11828-add-backwards-compatibility
…d-api-and-codegen

[MOB-11826] make-frontend-api-and-codegen
…ew-arch/MOB-11828-add-backwards-compatibility
…ew-arch/MOB-11828-add-backwards-compatibility
…s-compatibility

[MOB-11828] add-backwards-compatibility
Added copilot suggestion

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…t suggestion

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…t suggestion

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…itecture-support

[MOB-11827] add-new-architecture-support
@lposen lposen marked this pull request as ready for review October 9, 2025 10:30
@lposen lposen changed the title New arch/master [SDK-82] New Architecture Oct 14, 2025
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed over all the files. Not deeply reviewed


// MOB-10421: Figure out what the error cases are and handle them appropriately
// This is just here to match the TS types and let the JS thread know when we are done initializing
promise.resolve(true);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 2 issues:

1. Function with high complexity (count = 5): initializeWithApiKey [qlty:function-complexity]


2. Function with many parameters (count = 4): initializeWithApiKey [qlty:function-parameters]

@ReactMethod
public void trackPushOpenWithCampaignId(Integer campaignId, Integer templateId, String messageId, Boolean appAlreadyRunning, ReadableMap dataFields) {
RNIterableInternal.trackPushOpenWithCampaignId(campaignId, templateId, messageId, optSerializedDataFields(dataFields));
public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]


@ReactMethod
public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, Integer campaignId, Integer templateId) {
public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

unsubscribedMessageTypeIds: number[] | null,
subscribedMessageTypeIds: number[] | null,
campaignId: number,
templateId: number
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

@lposen lposen merged commit 91937fe into master Nov 3, 2025
12 of 14 checks passed
@lposen lposen deleted the new-arch/master branch November 3, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants