[MOB-12260] create-embedded-tab-in-example-app #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

lposen merged 7 commits into loren/embedded/master from loren/embedded/MOB-12260-create-embedded-tab-in-example-app

Dec 15, 2025

Contributor

lposen commented Oct 10, 2025 •

edited

Loading

🔹 JIRA Ticket(s) if any

MOB-12260

✏️ Description

Adds the embedded tab to example app

Tests

cd into the example folder and run:

yarn install
watchman watch-del-all
yarn start --reset-cache

In a separate terminal, cd into the example folder then build for either ios (yarn ios) or android (yarn android)
The example app should open, and should contain a tab which reads "Embedded":


          docs: add Embedded component to example app

1ac7370

lposen changed the base branch from master to loren/embedded/master

October 10, 2025 22:10

github-actions bot commented Oct 10, 2025 •

edited

Loading

Lines	Statements	Branches	Functions
	58.68% (331/564)	33.76% (78/231)	57.56% (118/205)

qltysh bot commented Oct 10, 2025 •

edited

Loading

Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help

Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.
Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.
File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)
- Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

qltysh bot commented Oct 10, 2025 •

edited

Loading

1 new issue

Tool	Category	Rule	Count
qlty	Structure	Function with high complexity (count = 15): requestNotificationPermission	1

qltysh bot reviewed

View reviewed changes

example/src/components/App/App.tsx Show resolved Hide resolved

qltysh bot reviewed

View reviewed changes

example/src/components/App/App.tsx Show resolved Hide resolved

lposen changed the base branch from loren/embedded/master to jwt/MOB-12298-new-improve-logger

October 10, 2025 23:43

qltysh bot reviewed

View reviewed changes

example/src/components/App/App.tsx Show resolved Hide resolved


          Merge branch 'jwt/MOB-12298-new-improve-logger' into loren/embedded/M…

f81b52d

…OB-12260-create-embedded-tab-in-example-app

qltysh bot reviewed

View reviewed changes

example/src/components/App/App.tsx Show resolved Hide resolved


          feat: add Embedded tab to Main component in example app

f456e20

qltysh bot reviewed

View reviewed changes

example/src/components/App/App.tsx Show resolved Hide resolved

lposen added the embedded label

lposen changed the base branch from jwt/MOB-12298-new-improve-logger to loren/embedded/master

October 14, 2025 20:25

qltysh bot reviewed

View reviewed changes

example/src/components/App/App.tsx Show resolved Hide resolved

lposen mentioned this pull request

[MOB-7052] Embedded messaging feature #751

Open


          Merge branch 'loren/embedded/master' into loren/embedded/MOB-12260-cr…

28173ed

…eate-embedded-tab-in-example-app

qltysh bot reviewed

View reviewed changes

example/src/components/App/App.tsx Show resolved Hide resolved


          Merge branch 'loren/embedded/master' into loren/embedded/MOB-12260-cr…

0be3376

…eate-embedded-tab-in-example-app

lposen marked this pull request as ready for review

November 19, 2025 04:58

qltysh bot reviewed

View reviewed changes

example/src/components/App/App.tsx Show resolved Hide resolved


          feat: add chat icon to route configuration in App.constants.ts

25ec86d

qltysh bot reviewed

View reviewed changes

example/src/components/App/App.tsx Show resolved Hide resolved


          Merge branch 'loren/embedded/master' into loren/embedded/MOB-12260-cr…

733ebd3

…eate-embedded-tab-in-example-app

qltysh bot reviewed

View reviewed changes

example/src/components/App/App.tsx

    
                      'Notification permission not required for this Android version.'

                    );

                  }

                }

qltysh bot Dec 11, 2025

Function with high complexity (count = 15): requestNotificationPermission [qlty:function-complexity]

joaodordio approved these changes

View reviewed changes

Member

joaodordio left a comment

LGTM!

lposen merged commit f5746ac into loren/embedded/master

8 checks passed

lposen deleted the loren/embedded/MOB-12260-create-embedded-tab-in-example-app branch

December 15, 2025 18:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels