Skip to content

Conversation

prudradeep
Copy link

No description provided.

@JKHeadley
Copy link
Owner

@prudradeep thanks so much! I will try to put aside some time in the near future to do a thorough review of all the recent PRs.

Copy link
Owner

@JKHeadley JKHeadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I added some comments on a few issues that I saw. Let me know if anything isn't clear.

Before this can be merged, we'll need to add sufficient tests to cover this endpoint. We'll also need to make sure the documentation is up to date and explains how this feature functions.

If you are interested in doing this, here are some starting points to reference:
https://github.com/JKHeadley/rest-hapi/blob/master/tests/unit/handler-helper.tests.js
https://github.com/JKHeadley/rest-hapi/blob/master/tests/unit/rest-helper-factory.tests.js
https://github.com/JKHeadley/rest-hapi/tree/master/tests/e2e

Please let me know if this is something you are interested in doing. Otherwise I will do my best to get to it when I can.

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants