-
Notifications
You must be signed in to change notification settings - Fork 2
Condify pyproject.toml, add fileglancer as an editable pypi dependency via pixi, use pixi reinstall #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@mkitti, I followed your instructions above and it worked as you showed, but afterwards when I tried either
|
You might need a |
@krokicki Running these two commands worked for me to then be able to use
|
To reproduce Konrad's issue:
AttributeError: module 'zmq.backend.cython' has no attribute 'PYZMQ_DRAFT_API'``` (fileglancer) (base) kittisopikulm@kittisopikulm-wm1 fileglancer % pixi run dev-launch ✨ Pixi task (dev-launch in default): NODE_ENV=development jupyter lab --autoreload Traceback (most recent call last): File "/Users/kittisopikulm/Documents/src/fileglancer/.pixi/envs/default/bin/jupyter-lab", line 6, in from jupyterlab.labapp import main File "/Users/kittisopikulm/Documents/src/fileglancer/.pixi/envs/default/lib/python3.13/site-packages/jupyterlab/__init__.py", line 8, in from .handlers.announcements import ( ...<3 lines>... ) File "/Users/kittisopikulm/Documents/src/fileglancer/.pixi/envs/default/lib/python3.13/site-packages/jupyterlab/handlers/announcements.py", line 16, in from jupyterlab_server.translation_utils import translator File "/Users/kittisopikulm/Documents/src/fileglancer/.pixi/envs/default/lib/python3.13/site-packages/jupyterlab_server/__init__.py", line 6, in from .app import LabServerApp File "/Users/kittisopikulm/Documents/src/fileglancer/.pixi/envs/default/lib/python3.13/site-packages/jupyterlab_server/app.py", line 10, in from jupyter_server.extension.application import ExtensionApp, ExtensionAppJinjaMixin File "/Users/kittisopikulm/Documents/src/fileglancer/.pixi/envs/default/lib/python3.13/site-packages/jupyter_server/extension/application.py", line 17, in from jupyter_server.serverapp import ServerApp File "/Users/kittisopikulm/Documents/src/fileglancer/.pixi/envs/default/lib/python3.13/site-packages/jupyter_server/serverapp.py", line 34, in import jupyter_client File "/Users/kittisopikulm/Documents/src/fileglancer/.pixi/envs/default/lib/python3.13/site-packages/jupyter_client/__init__.py", line 3, in from .asynchronous import AsyncKernelClient File "/Users/kittisopikulm/Documents/src/fileglancer/.pixi/envs/default/lib/python3.13/site-packages/jupyter_client/asynchronous/__init__.py", line 1, in from .client import AsyncKernelClient # noqa ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/kittisopikulm/Documents/src/fileglancer/.pixi/envs/default/lib/python3.13/site-packages/jupyter_client/asynchronous/client.py", line 8, in import zmq.asyncio File "/Users/kittisopikulm/Documents/src/fileglancer/.pixi/envs/default/lib/python3.13/site-packages/zmq/__init__.py", line 52, in from zmq import backend File "/Users/kittisopikulm/Documents/src/fileglancer/.pixi/envs/default/lib/python3.13/site-packages/zmq/backend/__init__.py", line 30, in raise original_error from None File "/Users/kittisopikulm/Documents/src/fileglancer/.pixi/envs/default/lib/python3.13/site-packages/zmq/backend/__init__.py", line 25, in _ns = select_backend(first) File "/Users/kittisopikulm/Documents/src/fileglancer/.pixi/envs/default/lib/python3.13/site-packages/zmq/backend/select.py", line 40, in select_backend ns.update({key: getattr(mod, key) for key in public_api}) ~~~~~~~^^^^^^^^^^ AttributeError: module 'zmq.backend.cython' has no attribute 'PYZMQ_DRAFT_API' ```Running |
* Replace ext-clean task with `pixi reinstall` * Have pip-install and pip-uninstall commands depend on ext-clean to trigger `pixi reinstall`
0f8888a
to
716b02a
Compare
Konrad needed to run |
Thanks, it worked after I ran I noticed that the new build is 50% slower for some reason. I tried each build twice, with a New:
Old:
New:
Old:
|
What are you timing specifically? I suspect that at the end of the day we may need less cleaning and that |
I'm timing the initial |
This replaces `pixi reinstall` which reinstalls everything
for checkZarrMetadata
I merged #182 into here for now because I could not push otherwise. |
I changed
Also, I should note that dev-install is unnecessary after a
This is because
Note that this is faster than @krokicki 's timings above. The one thing you might need |
On my Mac Studio the time is less than 20 seconds from clean to launch due to caching: clean_to_launch.mov |
With an edit, it is just a few more seconds: edit_reinstall.mov |
pixi reinstall
pip-install
(pip install -e .
) withpixi reinstall
pip-uninstall
withpixi clean
Current main branch
This pull request
Another benefit is that a large part of
dev-install
, particularlypip install -e .
can be replaced bypixi reinstall
. If a source file is changed,pixi reinstall
will rebuild the package. If nothing is changed,pixi reinstall
will use its build cache.Therefore, the
pip
commands have been replaced withpixi reinstall
andpixi clean
.Previously, I thought of removing or replacing the task
ext-clean
, but I have left it in place. It may be less necessary now though due topixi reinstall
's behavior.