Skip to content

fix: check zarrv3 before zarrv2 #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2025
Merged

fix: check zarrv3 before zarrv2 #195

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bd4a9c
fix: switch order of conditionals to check zarr v3 first
allison-truhlar Oct 6, 2025
34953be
chore: linting
allison-truhlar Oct 6, 2025
7e9c0f8
Merge branch 'main' into check-zarrv3-before-zarrv2
allison-truhlar Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 29 additions & 29 deletions src/hooks/useZarrMetadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,44 +156,44 @@ export default function useZarrMetadata() {
fileBrowserState.currentFileOrFolder.path
);

const zarrayFile = getFile('.zarray');
if (zarrayFile) {
await checkZarrArray(imageUrl, 2, signal);
} else {
const zattrsFile = getFile('.zattrs');
if (zattrsFile) {
const attrs = (await fetchFileAsJson(
fileBrowserState.currentFileSharePath.name,
zattrsFile.path,
cookies
)) as any;
if (signal.aborted) {
return;
}
if (attrs.multiscales) {
await checkOmeZarrMetadata(imageUrl, 2, signal);
const zarrJsonFile = getFile('zarr.json');
if (zarrJsonFile) {
const attrs = (await fetchFileAsJson(
fileBrowserState.currentFileSharePath.name,
zarrJsonFile.path,
cookies
)) as any;
if (signal.aborted) {
return;
}
if (attrs.node_type === 'array') {
await checkZarrArray(imageUrl, 3, signal);
} else if (attrs.node_type === 'group') {
if (attrs.attributes?.ome?.multiscales) {
await checkOmeZarrMetadata(imageUrl, 3, signal);
} else {
log.info('Zarrv3 group has no multiscales', attrs.attributes);
}
} else {
const zarrJsonFile = getFile('zarr.json');
if (zarrJsonFile) {
log.warn('Unknown Zarrv3 node type', attrs.node_type);
}
} else {
const zarrayFile = getFile('.zarray');
if (zarrayFile) {
await checkZarrArray(imageUrl, 2, signal);
} else {
const zattrsFile = getFile('.zattrs');
if (zattrsFile) {
const attrs = (await fetchFileAsJson(
fileBrowserState.currentFileSharePath.name,
zarrJsonFile.path,
zattrsFile.path,
cookies
)) as any;
if (signal.aborted) {
return;
}
if (attrs.node_type === 'array') {
await checkZarrArray(imageUrl, 3, signal);
} else if (attrs.node_type === 'group') {
if (attrs.attributes?.ome?.multiscales) {
await checkOmeZarrMetadata(imageUrl, 3, signal);
} else {
log.info('Zarrv3 group has no multiscales', attrs.attributes);
}
} else {
log.warn('Unknown Zarrv3 node type', attrs.node_type);
if (attrs.multiscales) {
await checkOmeZarrMetadata(imageUrl, 2, signal);
}
}
}
Expand Down