fix: Restores breadcrumb to folders without access permission. #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will show the breadcrumbs for folders and files that were previously hidden when permissions didn't allow access. The root cause was that the 403 error response in the fetchFileInfo function was throwing away the body.info, which meant it couldn't be used to create a FileOrFolder object in the fetchAndUpdateFileBrowserState function. This updated passes that information into the catch block, so that it can still be used to show the UI. Now that this is working, the properties UI shows the convert tab, and the overview tab has the create data link switch. Both of those components should probably be hidden in this case. To do that, we either need to use a blunt approach and just hide them when the api responds with a 403 or we need to use the body.info information and compare that to the currently logged in user.
@krokicki @allison-truhlar