JSON Encoder

[alanzhang25]

📝 Summary

• 1. ...

🎥 Demo of Changes

✅ Checklist

• Tagged Linear ticket in PR title. Ie. PR Title (JUD-XXXX)
• Video demo of changes
• Reviewers assigned
• Docs updated (if necessary)
• Cookbooks updated (if necessary)

[gemini-code-assist]

Summary of Changes

Hello @alanzhang25, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to standardize and centralize JSON encoding practices across the codebase. By introducing a new json_encoder utility based on FastAPI's jsonable_encoder, it replaces various ad-hoc and orjson-specific serialization methods, leading to more consistent, robust, and maintainable data serialization for API requests and internal data structures.

Highlights

• New JSON Encoder Utility: A new module, src/judgeval/common/api/json_encoder.py, has been introduced. It provides a centralized json_encoder function that leverages FastAPI's jsonable_encoder for robust serialization of various Python types, including Pydantic models, with a fallback to repr() for unencodable objects.
• Dependency Update: The fastapi library (version >=0.116.1) has been added as a new dependency in pyproject.toml to support the integration of jsonable_encoder.
• Consolidation of Serialization Logic: Multiple custom and orjson-specific serialization methods across the codebase, such as _serialize in api.py, _safe_json_handle in span_transformer.py, and _serialize_value in trace.py, have been removed and replaced with calls to the new, unified json_encoder.
• Improved API Request Handling: The JudgmentAPIClient now utilizes the new json_encoder when making requests, passing the serialized payload via the json parameter of the requests library, which simplifies and standardizes API payload serialization.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

[abhishekg999]

Also travel_agent fails idk if this is me but it seems to have to do with updates.

[abhishekg999]

Lets revert the uv.lock and pyproject.toml, and check travel_agent for testing

[abhishekg999]

looks good, check the few nonblocking comments and feel free to update if desired.
I tested this locally and it looks good.

[abhishekg999]

nice!