Skip to content

perf: add basic precompilation #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2025
Merged

perf: add basic precompilation #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d003e4a
perf: add basic precompilation
mortenpi Apr 1, 2025
5909c87
also precompile nodespecs
mortenpi Apr 1, 2025
eafbf0b
fix formatting
mortenpi Apr 1, 2025
0cb9ba8
also batch job submit
mortenpi Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/JuliaHub.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,6 @@ macro _mark_names_public()
end
@_mark_names_public

include("precompile.jl")

end
31 changes: 31 additions & 0 deletions src/precompile.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
precompile(JuliaHub.authenticate, ())
precompile(JuliaHub.authenticate, (Nothing,))
precompile(JuliaHub.authenticate, (String,))
precompile(JuliaHub.authenticate, (String, String))

precompile(JuliaHub.datasets, ())
precompile(JuliaHub.datasets, (String,))
precompile(JuliaHub.dataset, (Dataset,))
precompile(JuliaHub.dataset, (String,))
precompile(JuliaHub.dataset, (Tuple{String, String},))

precompile(JuliaHub.jobs, ())
precompile(JuliaHub.job, (Job,))
precompile(JuliaHub.job, (String,))

precompile(JuliaHub.nodespecs, ())
precompile(JuliaHub.batchimages, ())
precompile(JuliaHub.batchimages, (String,))
precompile(JuliaHub.appbundle, (String,))
precompile(JuliaHub.appbundle, (String, String))
precompile(JuliaHub.submit_job, (WorkloadConfig,))
precompile(JuliaHub.submit_job, (BatchJob,))

# Precompile the basic show() methods for all public types
for sym in JuliaHub._find_public_names()
t = getfield(@__MODULE__, sym)
if isa(t, DataType)
precompile(Base.show, (Base.TTY, MIME"text/plain", t))
precompile(Base.show, (Base.TTY, MIME"text/plain", Vector{t}))
end
end
Loading