Skip to content

fix: handle empty JULIAHUB_PROJECT_UUID var correctly #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

fix: handle empty JULIAHUB_PROJECT_UUID var correctly #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/authentication.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,10 +506,12 @@ _authentication(server::AbstractString; kwargs...) = _authentication(URIs.URI(se
function _juliahub_project(
project::Union{AbstractString, UUIDs.UUID, Nothing, Missing}
)::Union{UUID, Nothing}
project = coalesce(
project,
get(ENV, "JULIAHUB_PROJECT_UUID", nothing),
)
project_env = strip(get(ENV, "JULIAHUB_PROJECT_UUID", ""))
if isempty(project_env)
project_env = nothing
end
project = coalesce(project, project_env)

if isnothing(project)
return nothing
elseif isa(project, UUIDs.UUID)
Expand Down
13 changes: 13 additions & 0 deletions test/authentication.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,25 @@
@test JuliaHub._juliahub_project(nothing) === nothing
@test JuliaHub._juliahub_project(missing) === nothing
end
withenv("JULIAHUB_PROJECT_UUID" => "") do
@test JuliaHub._juliahub_project(uuid1) == UUIDs.UUID(uuid1)
@test_throws ArgumentError JuliaHub._juliahub_project("invalid")
@test_throws ArgumentError JuliaHub._juliahub_project("")
@test JuliaHub._juliahub_project(nothing) === nothing
@test JuliaHub._juliahub_project(missing) === nothing
end
withenv("JULIAHUB_PROJECT_UUID" => " ") do
@test JuliaHub._juliahub_project(missing) === nothing
end
withenv("JULIAHUB_PROJECT_UUID" => uuid1) do
@test JuliaHub._juliahub_project(uuid2) == UUIDs.UUID(uuid2)
@test_throws ArgumentError JuliaHub._juliahub_project("invalid")
@test JuliaHub._juliahub_project(nothing) === nothing
@test JuliaHub._juliahub_project(missing) === UUIDs.UUID(uuid1)
end
withenv("JULIAHUB_PROJECT_UUID" => " $(uuid1) ") do
@test JuliaHub._juliahub_project(missing) == UUIDs.UUID(uuid1)
end
end

@testset "JuliaHub.authenticate()" begin
Expand Down
Loading