Skip to content

Allow return statements for GPU-only kernels #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Allow return statements for GPU-only kernels #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e124181
Allow return statements for GPU-only kernels
pxl-th Oct 18, 2024
860c71f
Add tests
pxl-th Oct 23, 2024
b3f6676
Refactor
pxl-th Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/macros.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ function __kernel(expr, generate_cpu = true, force_inbounds = false)
def = splitdef(expr)
name = def[:name]
args = def[:args]
find_return(expr) && error("Return statement not permitted in a kernel function $name")
generate_cpu && find_return(expr) && error(
"Return statement not permitted in a kernel function $name",
)

constargs = Array{Bool}(undef, length(args))
for (i, arg) in enumerate(args)
Expand Down
18 changes: 18 additions & 0 deletions test/test.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,4 +306,22 @@ function unittest_testsuite(Backend, backend_str, backend_mod, BackendArrayT; sk
@test size(KernelAbstractions.zeros(backend, Float32, 0, 9)) == (0, 9)
end

@kernel cpu = false function gpu_return_kernel!(x)
i = @index(Global)
if i ≤ (length(x) ÷ 2)
x[i] = 1
return
end
end
@testset "GPU kernel return statement" begin
if !(Backend() isa CPU)
A = KernelAbstractions.zeros(Backend(), Int64, 1024)
gpu_return_kernel!(Backend())(A; ndrange = length(A))
synchronize(Backend())
Ah = Array(A)
@test all(a -> a == 1, @view(Ah[1:(length(A) ÷ 2)]))
@test all(a -> a == 0, @view(Ah[(length(A) ÷ 2 + 1):end]))
end
end

end
Loading