Skip to content

Conversation

axsk
Copy link

@axsk axsk commented Jan 6, 2025

Summary

Proposed changes

  • ...

What alternatives have you considered?

Breaking changes

@theogf
Copy link
Member

theogf commented Jan 7, 2025

You would need to make sure that the new behaviour of @functor is still correct (it looks like now being a leaf is opt-in rather than opt-out)

@gnadt
Copy link
Contributor

gnadt commented Feb 1, 2025

I'll kindly note that KernelFunctions is indirectly limiting other packages (via the Functors dependency) from updating Flux. Our package will unfortunately have to drop KernelFunctions instead. I'm not familiar with the internals or testing of the KernelFunctions package, but the CI results on 1.6 and 1 for this PR looks to be the same as the previous PR.

@theogf
Copy link
Member

theogf commented Feb 1, 2025

I will take a closer look.

@theogf
Copy link
Member

theogf commented Feb 2, 2025

It looks like the tests are failing like on master, however inspecting the resolution it looks like 0.4.12 was used in the tests. @axsk could you also update the compat in test/Project.toml?

@sathvikbhagavan
Copy link

A gentle bump on this. Its blocking upgrading Flux in Surrogates.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants