Skip to content

Backports for Julia 1.11.x #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2025
Merged

Backports for Julia 1.11.x #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6f0f02
Merge pull request #137 from JuliaLang/dpa/dont-use-link-local
DilumAluthge Jun 16, 2025
ded3ced
Bump actions/cache from 1 to 4 (#98)
dependabot[bot] Jul 24, 2024
7fb6e8d
`release-julia-1.11`: Run CI on Julia 1.11.x (#142)
DilumAluthge Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
fail-fast: false
matrix:
version:
- 'nightly'
- '1.11' # This is the `release-julia-1.11` branch, so we run CI on Julia 1.11.x
os:
- ubuntu-latest
- macOS-latest
Expand All @@ -39,7 +39,7 @@ jobs:
with:
version: ${{ matrix.version }}
arch: ${{ matrix.arch }}
- uses: actions/cache@v1
- uses: actions/cache@v4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also switch to julia-actions/cache: #116
(but this is fine too)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I imagine the CI frequency on this branch will be pretty low-frequency, so probably not too pressing.

env:
cache-name: cache-artifacts
with:
Expand All @@ -64,7 +64,7 @@ jobs:
- uses: julia-actions/setup-julia@latest
with:
# version: '1.6'
version: 'nightly'
version: '1.11' # This is the `release-julia-1.11` branch, so we run CI on Julia 1.11.x
- name: Generate docs
run: |
julia --color=yes -e 'write("Project.toml", replace(read("Project.toml", String), r"uuid = .*?\n" =>"uuid = \"47e2e46d-f89d-539d-b4ee-838fcccc9c8e\"\n"));'
Expand Down
24 changes: 23 additions & 1 deletion src/cluster.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1262,6 +1262,28 @@ function terminate_all_workers()
end
end

function choose_bind_addr()
# We prefer IPv4 over IPv6.
#
# We also prefer non-link-local over link-local.
# (This is because on HPC clusters, link-local addresses are usually not
# usable for communication between compute nodes.
#
# Therefore, our order of preference is:
# 1. Non-link-local IPv4
# 2. Non-link-local IPv6
# 3. Link-local IPv4
# 4. Link-local IPv6
addrs = getipaddrs()
i = something(
findfirst(ip -> !islinklocaladdr(ip) && ip isa IPv4, addrs), # first non-link-local IPv4
findfirst(ip -> !islinklocaladdr(ip) && ip isa IPv6, addrs), # first non-link-local IPv6
findfirst(ip -> ip isa IPv4, addrs), # first IPv4
findfirst(ip -> ip isa IPv6, addrs), # first IPv6
)
return addrs[i]
end

# initialize the local proc network address / port
function init_bind_addr()
opts = JLOptions()
Expand All @@ -1276,7 +1298,7 @@ function init_bind_addr()
else
bind_port = 0
try
bind_addr = string(getipaddr())
bind_addr = string(choose_bind_addr())
catch
# All networking is unavailable, initialize bind_addr to the loopback address
# Will cause an exception to be raised only when used.
Expand Down
Loading