[WIP] Allow setting a command prefix for the sysimage build command #870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #870 +/- ##
==========================================
- Coverage 84.94% 84.26% -0.68%
==========================================
Files 3 3
Lines 797 801 +4
==========================================
- Hits 677 675 -2
- Misses 120 126 +6
|
It is not necessary to provide a prefix in the build phase but it may be necessary when the script given by `precompile_execution_file` is executed, e.g. if some package requires the script to be run in an MPI context via `mpirun`. Thus, this reverts commit d3b7edc.
This change adds some flexibility to how precompile execution files are executed by PackageCompiler to generate precompile statements. In some cases, for example when one wants to use precompile statements generated from a script that uses a package that uses MPI and requires that the Julia process is started via `mpiexec` or similar, one currently has to execute the script manually and use Julia's `--trace-compile` option to generate precompile statements and pass them manually to PackageCompiler afterwards. The new `precompile_execution_prefix` keyword argument introduced by this commit allows one to skip manual generation of precompile statements in such cases by passing the necessary prefix to PackageCompiler.
lchristm
force-pushed
the
msl/allow-sysimage-build-command-prefix
branch
from
22fa0de to
38c58d8
Compare
|
@sloede The prefix is only needed for executing scripts passed via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new, optional
sysimage_build_prefixkwarg tocreate_{sysimage,app,library}. It aims to allow one to prepend the build command called when creating a sysimage with a user-specified command prefix.The main motivation is to be able to call PackageCompiler.jl from within an MPI-started process. This is sometimes required on supercomputers, where calling MPI functions without having started a process via
mpirun/srun/aprunetc. is disabled.cc @lchristm