Skip to content

REPL: hide any prints to stdio during complete_line #55959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2024
Merged

REPL: hide any prints to stdio during complete_line #55959

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56c73a0
hide any prints to stdio during `complete_line`
IanButterworth Oct 1, 2024
69caecd
Merge branch 'master' into ib/repl_complete_noprint
IanButterworth Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions stdlib/REPL/src/LineEdit.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,14 @@ end
# Prompt Completions & Hints
function complete_line(s::MIState)
set_action!(s, :complete_line)
if complete_line(state(s), s.key_repeats, s.active_module)
# suppress stderr/stdout prints during completion computation
# i.e. ambiguous qualification warnings that are printed to stderr
# TODO: remove this suppression once such warnings are better handled
# TODO: but before that change Pipe to devnull once devnull redirects work for JL_STDERR etc.
completions_exist = redirect_stdio(;stderr=Pipe(), stdout=Pipe()) do
complete_line(state(s), s.key_repeats, s.active_module)
end
if completions_exist
return refresh_line(s)
else
beep(s)
Expand All @@ -384,7 +391,13 @@ function check_for_hint(s::MIState)
end

completions, partial, should_complete = try
complete_line(st.p.complete, st, s.active_module; hint = true)::Tuple{Vector{String},String,Bool}
# suppress stderr/stdout prints during completion computation
# i.e. ambiguous qualification warnings that are printed to stderr
# TODO: remove this suppression once such warnings are better handled
# TODO: but before that change Pipe to devnull once devnull redirects work for JL_STDERR etc.
completions, partial, should_complete = redirect_stdio(;stderr=Pipe(), stdout=Pipe()) do
complete_line(st.p.complete, st, s.active_module; hint = true)::Tuple{Vector{String},String,Bool}
end
catch
@debug "error completing line for hint" exception=current_exceptions()
return clear_hint(st)
Expand Down