Skip to content

Fix and test Float16 Rational comparison #58217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+6 −1
Open

Fix and test Float16 Rational comparison #58217

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
936147b
Fix and test float16 rational comparison
LilithHafner Apr 24, 2025
a9600c3
Simplify
LilithHafner Apr 24, 2025
e94dd3e
Update base/rational.jl
LilithHafner Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions base/rational.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,7 @@ fma(x::Rational, y::Rational, z::Rational) = x*y+z
<=(x::Rational, y::Integer ) = x.num <= widemul(x.den,y)
<=(x::Integer , y::Rational) = widemul(x,y.den) <= y.num

==(x::Float16, q::Rational) = widen(x) == q
function ==(x::AbstractFloat, q::Rational)
if isfinite(x)
(count_ones(q.den) == 1) & (x*q.den == q.num)
Expand Down
5 changes: 5 additions & 0 deletions test/rational.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,3 +837,8 @@ end
@test_throws OverflowError numerator(Int8(1)//Int8(31) + Int8(8)im//Int8(3))
end
end

@testset "Float16 comparison" begin
@test Float16(6.0e-8) == big(1//16777216) == 1//16777216
@test Float16(6.0e-8) == 1//16777216
end