-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
fix show
of self referential arrays
#58863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
==
on self referential arrays, as well as show
show
of self referential arrays
look ok?
|
…refarray_fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this was usually only handled at the start of applicable show methods, not each element (part 1 but not part 2 of this PR)?
ok, I just check it in note that the alignment is a bit funky for showing in REPL
but fixing the alignment seems quite involved and ideally I'd leave that to a separate PR edit: looks like that issue is #40547 |
see the tests for some MWE this fixes
closes #47280