-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Backports for 1.12.0-rc2 #59110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Backports for 1.12.0-rc2 #59110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rc2 presumably? |
6dd681b
to
0f3c365
Compare
I just did a rebase. Seemed |
This comment was marked as resolved.
This comment was marked as resolved.
0f3c365
to
a602e1a
Compare
I looked at all the usage sites of these constructors within the compiler, and fortunately it appears that none of the usage sites require that the return values of these constructors be objects of their respective types. So in cases where `LimitedAccuracy` is given as a wrapped element, these slot type refinements simply will not be performed. - fixes #59004
``` julia> Base.throw(x::Int) = 1 ERROR: cannot add methods to builtin function `throw` Stacktrace: [1] top-level scope @ REPL[1]:1 ``` (cherry picked from commit 57def4d)
(cherry picked from commit fde79f5)
(cherry picked from commit 9f69961)
(cherry picked from commit 1f6eff1)
Fix #59128 Assignment desugaring of `(const (= (|::| x T) rhs))` would pre-expand to, then re-expand `(const x ,(convert-for-type-decl rhs T))`, but two-arg (IR) const is expected to have a simple RHS---closure conversion doesn't recurse here (should it?), giving us partially-lowered IR, and hence our bug. Fix: Pre-expand to the one-arg AST const form `(const (= x ,(convert-for-type-decl rhs T)))` instead. This also gives us a `(latestworld)` we were missing before, so this lowering may have been originally intended. (cherry picked from commit 3de5b9a)
(cherry picked from commit f9b7d27)
This had failed to be updated for the LazyLibrary changes to codegen. (cherry picked from commit 46c2a5c)
Needs to be modified on 1.12 since Zstd_jll is not an stdlib. |
Not sure why we make sure compile go slow, so make it go fast. (cherry picked from commit 095fc99)
We can probably use libz instead |
These modifications to the MethodTable should be performed at the "link-stage", after all user top-level code has executed. This should be closer to the upcoming 1.13 pipeline, which will move all top-level user code to its standard package execution context. This also makes any user-provided functionality for type printing available to the `TrimVerifier`. Resolves #59280.
…lgebra (#59299) We may want to move this changes to base proper. @LilithHafner should sort functions just always specialize on the `by`/`lt` params? It currently sometimes relies on inlining for good performance --------- Co-authored-by: Cody Tapscott <84105208+topolarity@users.noreply.github.com> Co-authored-by: Cody Tapscott <topolarity@tapscott.me>
…59232) This prevents accidentally registering hooks during the sysimage build that would persist to run-time (unlike what happens when registering hooks while building a pkgimage) ~~Required for JuliaLang/LinearAlgebra.jl#1407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported PRs:
const x::T = y
for complexy
#59155GlobalMethods
tomethodtable
🚲 🏠 #59158args
in juliac like it is elsewhere #59279Need manual backport:
Contains multiple commits, manual intervention needed:
Non-merged PRs with backport label:
_assert_to_string
indirection forExpr
-evaluated@assert
#59298buildscript
modifications after user code #59297Base.disable_library_threading_hooks
ephemeral to the process #59232@allocated
more reliable and handle assignment syntax #59278macroexpand!
function and addlegacyscope
kwarg #59276--trace-compile
#58535transcode
: prevent Windows sysimage invalidation #58038@nospecialize
forstring_index_err
#57604maxthreadid
fromThreads
#57490