document metrics from GC_Num; rename one metric from GC_Num to match the name used by the equivalent C struct #60115
Conversation
…the name used by the equivalent C struct
d-netto
force-pushed
the
dcn-add-comments-to-gc-metrics
branch
from
6709139 to
9f595eb
Compare
|
Note: confirm whether renaming the |
| total_allocd::Int64 | ||
| # (GC internal) Per-thread allocation quota before triggering a GC | ||
| # NOTE: This field is no longer used by the heuristics in the stock GC | ||
| interval::Csize_t |
There was a problem hiding this comment.
Apart from this change, LGTM. Will a nanosoldier run show how much breakage this will cause?
There was a problem hiding this comment.
@d-netto If you want to make this non-breaking, you can keep both names, and leave a comment saying the old one is deprecated and will be removed in future versions.
You can possible even mark it deprecated? I don't know if that's possible to do for a field.
There was a problem hiding this comment.
Let's wait for the results of PkgEval.
If only a few packages are using this field, then I'm inclined to just remove it and open issues on those packages to inform them that they should use interval instead.
|
@nanosoldier |
|
The package evaluation job you requested has completed - possible new issues were detected. Report summary❗ Packages that crashed9 packages crashed on the previous version too. ✖ Packages that failed15 packages failed only on the current version.
1509 packages failed on the previous version too. ✔ Packages that passed tests5 packages passed tests only on the current version.
5414 packages passed tests on the previous version too. ~ Packages that at least loaded3280 packages successfully loaded on the previous version too. ➖ Packages that were skipped altogether900 packages were skipped on the previous version too. |
|
I've looked over the test failures in the |
See PR title. I plan to clean up the GC metrics code a bit more in subsequent PRs.