-
Notifications
You must be signed in to change notification settings - Fork 54
Replace __init__
with OncePerProcess
on supported Julia versions
#316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #316 +/- ##
==========================================
+ Coverage 70.99% 71.50% +0.50%
==========================================
Files 5 5
Lines 531 544 +13
==========================================
+ Hits 377 389 +12
- Misses 154 155 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CC @giordano, would you be able to review and release this change if it looks ok? Thanks! |
For what is worth, with FFTW.jl v1.8.1: % for i in {1..5}; do julia +nightly --project=/tmp -e '@time using FFTW'; done
0.057132 seconds (69.55 k allocations: 4.520 MiB, 4.67% compilation time)
0.056803 seconds (69.55 k allocations: 4.520 MiB, 4.87% compilation time)
0.056254 seconds (69.55 k allocations: 4.520 MiB, 4.78% compilation time)
0.059455 seconds (69.55 k allocations: 4.520 MiB, 4.53% compilation time)
0.056675 seconds (69.55 k allocations: 4.520 MiB, 4.71% compilation time) On dbcb5d2 % for i in {1..5}; do julia +nightly --project=/tmp -e '@time using FFTW'; done
0.053584 seconds (69.61 k allocations: 4.526 MiB)
0.053191 seconds (69.61 k allocations: 4.526 MiB)
0.053056 seconds (69.61 k allocations: 4.526 MiB)
0.053553 seconds (69.61 k allocations: 4.526 MiB)
0.053436 seconds (69.61 k allocations: 4.526 MiB) Not much faster, but it seems to be consistently faster. |
… improvements We had initially planned a breaking change design for LazyLibrary, which this package was updated for, but later we realized a better design which allows going back to the original version of this code. The previous form is still very poorly supported in the compiler and was still rather buggy internally. Revert "Replace `__init__` with `OncePerProcess` on supported Julia versions (#316)" This reverts commit dbcb5d2. Revert "Make FFTW relocatable for PackageCompiler" This reverts commit e96270a.
… improvements We had initially planned a breaking change design for LazyLibrary, which this package was updated for, but later we realized a better design which allows going back to the original version of this code. The previous form is still very poorly supported in the compiler and was still rather buggy internally. Revert "Replace `__init__` with `OncePerProcess` on supported Julia versions (#316)" This reverts commit dbcb5d2. Revert "Make FFTW relocatable for PackageCompiler" This reverts commit e96270a.
… improvements We had initially planned a breaking change design for LazyLibrary, which this package was updated for, but later we realized a better design which allows going back to the original version of this code. The previous form is still very poorly supported in the compiler and was still rather buggy internally. Revert "Replace `__init__` with `OncePerProcess` on supported Julia versions (#316)" This reverts commit dbcb5d2. Revert "Make FFTW relocatable for PackageCompiler" This reverts commit e96270a.
…rary improvements (#318) We had initially planned a breaking change design for LazyLibrary, which this package was updated for, but later we realized a better design which allows going back to the original version of this code. The previous form is still very poorly supported in the compiler and was still rather buggy internally. Revert "Replace `__init__` with `OncePerProcess` on supported Julia versions (#316)" This reverts commit dbcb5d2. Revert "Make FFTW relocatable for PackageCompiler" This reverts commit e96270a. Refs: [ccall: make distinction of pointer vs name a syntactic distinction](JuliaLang/julia#59165)
No description provided.