Skip to content

make hessians of scaled interpolants work #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025
Merged

Conversation

ajwheeler
Copy link
Contributor

fixes #627

@ajwheeler ajwheeler marked this pull request as ready for review May 16, 2025 15:24
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.96%. Comparing base (ba5b9ec) to head (a625a34).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
+ Coverage   87.74%   87.96%   +0.21%     
==========================================
  Files          29       29              
  Lines        1910     1911       +1     
==========================================
+ Hits         1676     1681       +5     
+ Misses        234      230       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bclyons12
Copy link

This successfully fixes #627 , both in the example given and in my full code. Note that you may want to remove the rand or seed it in the test to avoid potentially irreproducible results in the future.

@ajwheeler
Copy link
Contributor Author

ajwheeler commented May 16, 2025

Interestingly, this test fails for u = reshape(collect((1.0 : (N^2))), N, N). (edit: to be clear, I think this is numerical, and may not fall into the category of being a "bug").

@mkitti
Copy link
Collaborator

mkitti commented May 17, 2025

Interestingly, this test fails for u = reshape(collect((1.0 : (N^2))), N, N). (edit: to be clear, I think this is numerical, and may not fall into the category of being a "bug").

Would it pass with an increased tolerance for isapprox?

@mkitti
Copy link
Collaborator

mkitti commented May 17, 2025

Could we bump the version to 0.16.1?

@mkitti mkitti merged commit 078a1b1 into JuliaMath:master May 19, 2025
14 checks passed
@ajwheeler
Copy link
Contributor Author

Sorry for the spam, but for anyone reading this in the future, u = reshape(collect((1.0 : (N^2))), N, N) has a condition number of roughly 1e19 for N = 10, so it's no surprise that the test fails for that input. (I should have realized this...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't compute ForwardDiff hessian
3 participants