Skip to content

silence 1.12 warnings #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

silence 1.12 warnings #80

merged 1 commit into from
Apr 14, 2025

Conversation

araujoms
Copy link
Contributor

@araujoms araujoms commented Apr 7, 2025

No description provided.

Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (b38f02f) to head (d7c9ceb).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   76.43%   78.12%   +1.68%     
==========================================
  Files           3        3              
  Lines         348      352       +4     
==========================================
+ Hits          266      275       +9     
+ Misses         82       77       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@araujoms
Copy link
Contributor Author

I hope my laconic PR wasn't perceived as rude; there is simply not much to say because this is such a simple change. Julia 1.12 issues warnings because Float16 and Float32 are not imported explicitly, so I added them to make it happy.

@simonbyrne simonbyrne merged commit afbce2c into JuliaMath:master Apr 14, 2025
12 checks passed
@simonbyrne
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants