Skip to content

Conversation

@ogauthe
Copy link

@ogauthe ogauthe commented Jul 9, 2025

Fix #498
also fixes ellipe.

@JeffreySarnoff
Copy link
Member

This looks good to me. Merge ready.
If you want, as the type here is Float64, triple-equals can be used to check for -Inf.

@codecov
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.03%. Comparing base (46a2874) to head (007bd3d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #499   +/-   ##
=======================================
  Coverage   94.02%   94.03%           
=======================================
  Files          14       14           
  Lines        2897     2901    +4     
=======================================
+ Hits         2724     2728    +4     
  Misses        173      173           
Flag Coverage Δ
unittests 94.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@inkydragon inkydragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix update branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ellipk(NaN) throws UndefVarError

3 participants