Skip to content

Update riscv64 fenv.c initialization to fix warnings #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

ViralBShah
Copy link
Member

@ViralBShah ViralBShah commented Jun 3, 2025

Mirrors the same change in aarch64.

@ViralBShah ViralBShah requested a review from Copilot June 3, 2025 22:57
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the default fenv_t environment initialization to use an aggregate initializer, addressing compiler warnings.

  • Replace scalar 0 initializer with aggregate {0}.

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.09%. Comparing base (9fbeafc) to head (2173bc0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   72.09%   72.09%           
=======================================
  Files         233      233           
  Lines        6139     6139           
  Branches     1607     1607           
=======================================
  Hits         4426     4426           
  Misses       1420     1420           
  Partials      293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ViralBShah ViralBShah closed this Jun 3, 2025
@ViralBShah ViralBShah reopened this Jun 4, 2025
@ViralBShah ViralBShah merged commit c9c6fd6 into master Jun 4, 2025
40 checks passed
@ViralBShah ViralBShah deleted the vs/riscv64-fenv-warnings branch June 4, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant