Skip to content

Conversation

MohamedLaghdafHABIBOULLAH

Add DiagonalBFGSModel where the hessian is approximated by DiagonalBFGS from LinearOperators.jl

@dpo
Copy link
Member

dpo commented Sep 12, 2024

We need a push!() method to update the operator.

@MohamedLaghdafHABIBOULLAH
Copy link
Author

MohamedLaghdafHABIBOULLAH commented Sep 12, 2024

@MohamedLaghdafHABIBOULLAH
Copy link
Author

@dpo pourrais tu me donner ton avis sur cette PR ?

@dpo
Copy link
Member

dpo commented Oct 15, 2024

I don’t think we want to maintain a nondiagonal LBFGS operator just to construct this one.

@MohamedLaghdafHABIBOULLAH
Copy link
Author

I don't quite get it. I did the same for other diagonal quasi-Newton updates, such as DiagonalPSBModel, DiagonalAndreiModel, and SpectralGradientModel, for which we have already defined quasi-Newton linear operators within LinearOperators.jl.

Should I do the same for all other diagonal updates and use only the quasi-Newton linear operators ?

@dpo
Copy link
Member

dpo commented Oct 28, 2024

There is no DiagonalBFGS operator in LinearOperators: https://github.com/search?q=repo%3AJuliaSmoothOptimizers%2FLinearOperators.jl%20DiagonalBFGS&type=code

@MohamedLaghdafHABIBOULLAH
Copy link
Author

There is no DiagonalBFGS operator in LinearOperators: https://github.com/search?q=repo%3AJuliaSmoothOptimizers%2FLinearOperators.jl%20DiagonalBFGS&type=code

That's why I opened this PR DBFGS

@dpo
Copy link
Member

dpo commented Feb 25, 2025

Before we can test this, we need a new release of LinearOperators and we need to update Project.toml here.

@MohamedLaghdafHABIBOULLAH
Copy link
Author

So should I open a PR to bump the version of LinearOperators.jl?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants