Skip to content

Conversation

Vanadjy
Copy link

@Vanadjy Vanadjy commented Aug 14, 2024

Adding a new problem to RegularizedOptimization : nonlinear SVM problem IJCNN1.

This is a new problem taken from LIBSVM which is compatible with the current structure of generating nonlinear svm problems. Like all other LIBSVM problem using the same activation function, it only requires for data to be loaded and use svm_model on it to generate an instance of the models.

What do you think about it @dpo, @MohamedLaghdafHABIBOULLAH ?

@dpo
Copy link
Member

dpo commented Aug 23, 2024

Please add unit tests. It looks like you're using modules that are not current dependencies.

@dpo
Copy link
Member

dpo commented Aug 28, 2024

@Vanadjy Please do not commit Manifest.toml.

@dpo
Copy link
Member

dpo commented Oct 6, 2024

@Vanadjy ⬆️

Also, your branch is out of sync. Could you please rebase?

@MohamedLaghdafHABIBOULLAH
Copy link
Collaborator

Thanks, @Vanadjy. Could you please rebase and sync this PR so we can proceed with the review?
I have a few general comments:

  • Remove Manifest.toml (as we can recreate your environment using instantiate)
  • It seems you've included some new packages needed conditionally for the IJCNN1 problem. I suggest handling them similarly tor fh_model.
  • Move these packages from deps to extras in Project.toml.

@dpo
Copy link
Member

dpo commented Apr 12, 2025

Bump @Vanadjy. ☝️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants