Skip to content

Conversation

MohamedLaghdafHABIBOULLAH
Copy link
Collaborator

@dpo The tests should now pass for Aqua.jl:

  • I updated to the most recent versions of LinearAlgebra, Random, and SparseArrays, which do not cause unsatisfied requirements errors.
  • I removed bpd_model_nls since it is not defined.

@MohamedLaghdafHABIBOULLAH
Copy link
Collaborator Author

It seems @dpo that there is a failing due to:

ERROR: 
The following 2 direct dependencies failed to precompile:
FHExt --code-coverage=@/tmp/cirrus-ci-build --color=yes --check-bounds=yes --warn-overwrite=yes --depwarn=yes --inline=yes --startup-file=no --track-allocation=none 
Failed to precompile FHExt [f87cc1d4-d00f-59f7-baf0-0d8b7fc90b20] to "/.julia/compiled/v1.11/FHExt/jl_lB8S5R".
ERROR: 
LoadError: InitError: could not load symbol "jl_true":
Invalid shared object handle 0x39bb0fe07408
Stacktrace:
ERROR: 
LoadError: Failed to precompile SciMLSensitivity [1ed8b502-d754-442c-8d5d-10ac956f44a1] to "/.julia/compiled/v1.11/SciMLSensitivity/jl_OvMK0D".```

Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (wip-bestie@94ff43d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/testset_bpdn.jl 50.00% 3 Missing ⚠️
src/testset_nnmf.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             wip-bestie      #76   +/-   ##
=============================================
  Coverage              ?   74.23%           
=============================================
  Files                 ?       22           
  Lines                 ?      458           
  Branches              ?        0           
=============================================
  Hits                  ?      340           
  Misses                ?      118           
  Partials              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds Aqua.jl testing to verify package quality standards including method ambiguities, package integrity, and coding best practices. The changes also clean up an undefined export from the bpdn_model.jl file.

  • Adds Aqua.jl dependency and corresponding test suite with ambiguity checking disabled
  • Removes undefined bpdn_nls_model export that was causing issues

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
test/runtests.jl Adds Aqua import and test suite execution
test/Project.toml Adds Aqua.jl as test dependency with version constraint
src/bpdn_model.jl Removes undefined bpdn_nls_model from exports

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dpo
Copy link
Member

dpo commented Sep 21, 2025

@MohamedLaghdafHABIBOULLAH You probably also need an if around using SciMLSensitivity here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants