-
Notifications
You must be signed in to change notification settings - Fork 7
Add aqua.jl test #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: wip-bestie
Are you sure you want to change the base?
Add aqua.jl test #76
Conversation
It seems @dpo that there is a failing due to: ERROR:
The following 2 direct dependencies failed to precompile:
FHExt --code-coverage=@/tmp/cirrus-ci-build --color=yes --check-bounds=yes --warn-overwrite=yes --depwarn=yes --inline=yes --startup-file=no --track-allocation=none
Failed to precompile FHExt [f87cc1d4-d00f-59f7-baf0-0d8b7fc90b20] to "/.julia/compiled/v1.11/FHExt/jl_lB8S5R".
ERROR:
LoadError: InitError: could not load symbol "jl_true":
Invalid shared object handle 0x39bb0fe07408
Stacktrace:
ERROR:
LoadError: Failed to precompile SciMLSensitivity [1ed8b502-d754-442c-8d5d-10ac956f44a1] to "/.julia/compiled/v1.11/SciMLSensitivity/jl_OvMK0D".``` |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## wip-bestie #76 +/- ##
=============================================
Coverage ? 74.23%
=============================================
Files ? 22
Lines ? 458
Branches ? 0
=============================================
Hits ? 340
Misses ? 118
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds Aqua.jl testing to verify package quality standards including method ambiguities, package integrity, and coding best practices. The changes also clean up an undefined export from the bpdn_model.jl file.
- Adds Aqua.jl dependency and corresponding test suite with ambiguity checking disabled
- Removes undefined
bpdn_nls_model
export that was causing issues
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
test/runtests.jl | Adds Aqua import and test suite execution |
test/Project.toml | Adds Aqua.jl as test dependency with version constraint |
src/bpdn_model.jl | Removes undefined bpdn_nls_model from exports |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…nant hors de FreeBSD
@MohamedLaghdafHABIBOULLAH You probably also need an |
d74f579
to
a59e5d5
Compare
…organization" This reverts commit bd6061b.
@dpo The tests should now pass for Aqua.jl: