-
Notifications
You must be signed in to change notification settings - Fork 7
Refactor workflows and improve code formatting across multiple files #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: wip-bestie
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## wip-bestie #77 +/- ##
=============================================
Coverage ? 75.97%
=============================================
Files ? 22
Lines ? 462
Branches ? 0
=============================================
Hits ? 351
Misses ? 111
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
λ = norm(grad(model, zeros(model.meta.nvar)), Inf) / 10 | ||
y = similar(model.meta.x0) | ||
grad!(model, y, zeros(model.meta.nvar)) | ||
λ = norm(y) / 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dpo The main change I made here was to avoid the error where grad
is not imported in the package, while grad!
is.
using Random | ||
using ManualNLPModels, NLPModels, ShiftedProximalOperators | ||
using Distributions, Noise, ProximalOperators | ||
import Base: /, convert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here @dpo, I specified the imports we use so that the ExplicitImports checks
pass.
If we could merge this as soon as possible, that would be great. |
I don't think it's possible to add conditionals to
We could try 3. If it doesn't work, we'll do 4. What do you think? |
@MohamedLaghdafHABIBOULLAH Please resolve the remaining issue with FreeBSD. |
@dpo I placed the pre-commit changes here so that the linting test for BP passes.