Skip to content

Conversation

MohamedLaghdafHABIBOULLAH
Copy link
Collaborator

@dpo I placed the pre-commit changes here so that the linting test for BP passes.

Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 69.44444% with 11 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (wip-bestie@94ff43d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/testset_nnmf.jl 0.00% 8 Missing ⚠️
src/testset_bpdn.jl 50.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             wip-bestie      #77   +/-   ##
=============================================
  Coverage              ?   75.97%           
=============================================
  Files                 ?       22           
  Lines                 ?      462           
  Branches              ?        0           
=============================================
  Hits                  ?      351           
  Misses                ?      111           
  Partials              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

λ = norm(grad(model, zeros(model.meta.nvar)), Inf) / 10
y = similar(model.meta.x0)
grad!(model, y, zeros(model.meta.nvar))
λ = norm(y) / 10
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpo The main change I made here was to avoid the error where grad is not imported in the package, while grad! is.

using Random
using ManualNLPModels, NLPModels, ShiftedProximalOperators
using Distributions, Noise, ProximalOperators
import Base: /, convert
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here @dpo, I specified the imports we use so that the ExplicitImports checks pass.

@MohamedLaghdafHABIBOULLAH
Copy link
Collaborator Author

If we could merge this as soon as possible, that would be great.

@dpo
Copy link
Member

dpo commented Sep 29, 2025

I don't think it's possible to add conditionals to Project.toml. The possible solutions are:

  1. we don't run unit tests on FreeBSD
  2. we disable precompilation always by adding __precompile__(false) at the top of the module (I think)
  3. we disable precompilation on Cirrus by setting the environment variable JULIA_PKG_PRECOMPILE_AUTO=0 in .cirrus.yml (I think)
  4. we exclude FH from the unit tests but use it in the benchmarks.

We could try 3. If it doesn't work, we'll do 4. What do you think?

@dpo
Copy link
Member

dpo commented Oct 1, 2025

@MohamedLaghdafHABIBOULLAH Please resolve the remaining issue with FreeBSD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants