-
Notifications
You must be signed in to change notification settings - Fork 49
added function aliases that dont contain unicode characters for convenience #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
=======================================
Coverage 97.33% 97.33%
=======================================
Files 36 36
Lines 3488 3488
=======================================
Hits 3395 3395
Misses 93 93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Phillip Alday <palday@users.noreply.github.com>
Added |
don't worry about it - the most impotartant thing is that the PR title is informative because we squash before merging. Now we just need tests, a minor version bump in Project.toml and an entry in NEWS.md. 😊 Tests can be super minimal, eg @test settheta! === setθ! (triple quotes to check identity instead of just equality) |
Thanks. I'll add the tests and a NEWS.md entry in some time |
87e31c4
to
b00cb94
Compare
okay i bumped up the version number to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more little thing, then I'll be ready to get it merged, so feel free to take it out of draft!
b00cb94
to
76b8d72
Compare
fixed the version number and (force) pushed! I wasnt sure what version number to put in so I just put something in hoping its right and if not get a suggestion |
this (draft) PR adds
settheta!
andprofilesigma
as aliases forsetθ!
andprofileσ
respectively. This is useful when displaying code in LaTeX. One place where this is really needed is arxiv preprints, as arxiv does not (currently) accept xelatex or lualatex, and making unicode symbols work in pdflatex adds a lot of burden.Tagging @dmbates as he might have suggestions/comments.