Skip to content

Conversation

ajinkya-k
Copy link
Contributor

this (draft) PR adds settheta! and profilesigma as aliases for setθ! and profileσ respectively. This is useful when displaying code in LaTeX. One place where this is really needed is arxiv preprints, as arxiv does not (currently) accept xelatex or lualatex, and making unicode symbols work in pdflatex adds a lot of burden.

Tagging @dmbates as he might have suggestions/comments.

@ajinkya-k ajinkya-k marked this pull request as ready for review February 24, 2025 20:09
@ajinkya-k ajinkya-k marked this pull request as draft February 24, 2025 20:09
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (09e6f1f) to head (76b8d72).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #805   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files          36       36           
  Lines        3488     3488           
=======================================
  Hits         3395     3395           
  Misses         93       93           
Flag Coverage Δ
current 96.98% <ø> (ø)
minimum 97.33% <ø> (ø)
nightly 96.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Phillip Alday <palday@users.noreply.github.com>
@ajinkya-k
Copy link
Contributor Author

Added const. Sorry for the uninformative commit message, I was trying out the GitHub "commit changes" website interface and accidentally hit commit before modifying the message. Do you want me to change it?

@palday
Copy link
Member

palday commented Feb 25, 2025

don't worry about it - the most impotartant thing is that the PR title is informative because we squash before merging.

Now we just need tests, a minor version bump in Project.toml and an entry in NEWS.md. 😊

Tests can be super minimal, eg

@test settheta! === setθ!

(triple quotes to check identity instead of just equality)

@ajinkya-k
Copy link
Contributor Author

Thanks. I'll add the tests and a NEWS.md entry in some time

@ajinkya-k ajinkya-k force-pushed the ahk/fn-nonunicode-alias branch from 87e31c4 to b00cb94 Compare February 25, 2025 14:58
@ajinkya-k
Copy link
Contributor Author

okay i bumped up the version number to 4.30.2 and added a NEWS.md entry, but there wasnt any 4.30.1 entry in there FYI. Feel free to make/suggest changes to the news or project toml

Copy link
Member

@palday palday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more little thing, then I'll be ready to get it merged, so feel free to take it out of draft!

@ajinkya-k ajinkya-k force-pushed the ahk/fn-nonunicode-alias branch from b00cb94 to 76b8d72 Compare February 25, 2025 17:10
@ajinkya-k
Copy link
Contributor Author

fixed the version number and (force) pushed! I wasnt sure what version number to put in so I just put something in hoping its right and if not get a suggestion

@ajinkya-k ajinkya-k marked this pull request as ready for review February 25, 2025 17:11
@palday palday merged commit bcd3e9f into JuliaStats:main Feb 25, 2025
12 checks passed
@ajinkya-k ajinkya-k deleted the ahk/fn-nonunicode-alias branch February 25, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants